All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org, Graf Yang <graf.yang@analog.com>
Subject: Re: [PATCH 1/2] serial: bfin_5xx: IRDA is not affected by anomaly 05000230
Date: Thu, 3 Jun 2010 10:42:03 -0700	[thread overview]
Message-ID: <20100603174203.GE9307@kroah.com> (raw)
In-Reply-To: <20100603174131.GD9307@kroah.com>

On Thu, Jun 03, 2010 at 10:41:31AM -0700, Greg KH wrote:
> On Mon, May 31, 2010 at 07:29:31AM -0400, Mike Frysinger wrote:
> > From: Graf Yang <graf.yang@analog.com>
> > 
> > Anomaly 05000230 (over sampling of the UART STOP bit) applies only when
> > the peripheral is operating in UART mode.  So drop the anomaly handling
> > when the UART is in IRDA mode.
> > 
> > Signed-off-by: Graf Yang <graf.yang@analog.com>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  drivers/serial/bfin_5xx.c |    7 ++++++-
> >  1 files changed, 6 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
> > index 96f7e74..a78652b 100644
> > --- a/drivers/serial/bfin_5xx.c
> > +++ b/drivers/serial/bfin_5xx.c
> > @@ -869,7 +869,12 @@ bfin_serial_set_termios(struct uart_port *port, struct ktermios *termios,
> >  	}
> >  
> >  	baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16);
> > -	quot = uart_get_divisor(port, baud) - ANOMALY_05000230;
> > +	quot = uart_get_divisor(port, baud);
> > +
> > +	/* If discipline is not IRDA, apply ANOMALY_05000230 */
> > +	if (termios->c_line != N_IRDA)
> > +		quot -= ANOMALY_05000230;
> > +
> 
> This can't be applied to the current tree, did you make it backwards?

Crap, that's because I already had it in my tree, doh...

  reply	other threads:[~2010-06-03 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-31 11:29 [PATCH 1/2] serial: bfin_5xx: IRDA is not affected by anomaly 05000230 Mike Frysinger
2010-05-31 11:29 ` [PATCH 2/2] serial: bfin_5xx: fix typo in IER check Mike Frysinger
2010-06-03 17:41 ` [PATCH 1/2] serial: bfin_5xx: IRDA is not affected by anomaly 05000230 Greg KH
2010-06-03 17:42   ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-05-23  8:40 Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100603174203.GE9307@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=graf.yang@analog.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.