From: Paul Moore <paul.moore@hp.com>
To: Eric Paris <eparis@redhat.com>
Cc: selinux@tycho.nsa.gov, Stephen Smalley <sds@tycho.nsa.gov>,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH 0/6] SELinux UNIX domain socket fixes/cleanup
Date: Thu, 3 Jun 2010 17:44:14 -0400 [thread overview]
Message-ID: <201006031744.14365.paul.moore@hp.com> (raw)
In-Reply-To: <1275599557.2828.1.camel@localhost>
On Thursday, June 03, 2010 05:12:37 pm Eric Paris wrote:
> On Thu, 2010-06-03 at 16:52 -0400, Paul Moore wrote:
> > On Saturday, May 29, 2010 05:53:16 pm Paul Moore wrote:
> > > For those of you using git, you can also find a copy of the patches at
> > > the URL below.
> > >
> > > * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing
> > >
> > > Thanks.
> >
> > Thoughts? Comments? ACKs? NACKs?
>
> I looked over the whole series and was good with them except I didn't
> know/understand the netlbl changes at the bottom of the first patch. I
> kept telling myself I was going to dig out the code and verify it's
> correctness but I haven't yet. Any chance you could explain what that
> change is all about to make it easier for me to verify it is correct?
Sure, let me give it a shot - I assume you're talking about the changes to
selinux_netlbl_sk_security_reset()? Assuming the answer is "yes", the reason
is that before it's inclusion in selinux_inode_setsecurity() it was always
called from functions operating on newly allocated sk_security_structs and as
a result it didn't need to worry about any old per-socket cached values (look
at selinux_netlbl_sock_genattr() to see what I mean about cached values and
sksec->nlbl_secattr). The change to selinux_netlbl_sk_security_reset() is to
check if a cache value exists and if it does clear it out before we relabel
the socket.
Anything else you're fuzzy on? I can't promise my explanations will help but
I can try ;)
> Patches 2-6 I'm ok adding my ACK to.....
Thanks!
--
paul moore
linux @ hp
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2010-06-03 21:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 21:53 [PATCH 0/6] SELinux UNIX domain socket fixes/cleanup Paul Moore
2010-05-29 21:53 ` [PATCH 1/6] selinux: Update socket's label alongside inode's label Paul Moore
2010-05-29 21:53 ` [PATCH 2/6] selinux: Set the peer label correctly on connected UNIX domain sockets Paul Moore
2010-05-29 21:53 ` [PATCH 3/6] selinux: Consolidate sockcreate_sid logic Paul Moore
2010-05-29 21:53 ` [PATCH 4/6] selinux: Shuffle the sk_security_struct alloc and free routines Paul Moore
2010-05-29 21:53 ` [PATCH 5/6] selinux: Convert socket related access controls to use socket labels Paul Moore
2010-05-29 21:53 ` [PATCH 6/6] selinux: Use current_security() when possible Paul Moore
2010-06-03 20:52 ` [PATCH 0/6] SELinux UNIX domain socket fixes/cleanup Paul Moore
2010-06-03 21:12 ` Eric Paris
2010-06-03 21:44 ` Paul Moore [this message]
2010-06-09 21:39 ` Paul Moore
2010-06-21 18:32 ` Paul Moore
2010-06-21 19:13 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006031744.14365.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.