From: Frederic Weisbecker <fweisbec@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>, Roland McGrath <roland@redhat.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: make save_stack_address() !CONFIG_FRAME_POINTER friendly
Date: Thu, 3 Jun 2010 21:52:00 +0200 [thread overview]
Message-ID: <20100603195157.GC5234@nowhere> (raw)
In-Reply-To: <20100603193239.GA31530@redhat.com>
On Thu, Jun 03, 2010 at 09:32:39PM +0200, Oleg Nesterov wrote:
> If CONFIG_FRAME_POINTER=n, print_context_stack() shouldn't neglect the
> non-reliable addresses on stack, this is all we have if dump_trace(bp)
> is called with the wrong or zero bp.
>
> For example, /proc/pid/stack doesn't work if CONFIG_FRAME_POINTER=n.
>
> This patch obviously has no effect if CONFIG_FRAME_POINTER=y, otherwise
> it reverts 1650743c "x86: don't save unreliable stack trace entries".
>
> Also, remove the unnecessary type-cast.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
next prev parent reply other threads:[~2010-06-03 19:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 19:32 [PATCH 1/2] x86: make save_stack_address() !CONFIG_FRAME_POINTER friendly Oleg Nesterov
2010-06-03 19:52 ` Frederic Weisbecker [this message]
2010-06-03 19:53 ` Arjan van de Ven
2010-06-03 20:06 ` Frederic Weisbecker
2010-06-03 20:31 ` Oleg Nesterov
2010-06-03 20:50 ` Frederic Weisbecker
2010-06-03 20:59 ` Oleg Nesterov
2010-06-09 18:17 ` [tip:perf/core] x86: Make " tip-bot for Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2010-06-08 20:13 [GIT PULL] perf updates Frederic Weisbecker
2010-06-08 20:13 ` [PATCH 1/2] x86: Make save_stack_address() !CONFIG_FRAME_POINTER friendly Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603195157.GC5234@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.