From: Jarod Wilson <jarod@redhat.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] IR: add mceusb IR receiver driver
Date: Thu, 3 Jun 2010 18:10:32 -0400 [thread overview]
Message-ID: <20100603221032.GD23375@redhat.com> (raw)
In-Reply-To: <4C0745DE.20306@redhat.com>
On Thu, Jun 03, 2010 at 03:04:14AM -0300, Mauro Carvalho Chehab wrote:
> Em 01-06-2010 17:32, Jarod Wilson escreveu:
> > This is a new driver for the Windows Media Center Edition/eHome
> > Infrared Remote transceiver devices. Its a port of the current
> > lirc_mceusb driver to ir-core, and currently lacks transmit support,
> > but will grow it back soon enough... This driver also differs from
> > lirc_mceusb in that it borrows heavily from a simplified IR buffer
> > decode routine found in Jon Smirl's earlier ir-mceusb port.
> >
> > This driver has been tested on the original first-generation MCE IR
> > device with the MS vendor ID, as well as a current-generation device
> > with a Topseed vendor ID. Every receiver supported by lirc_mceusb
> > should work equally well. Testing was done primarily with RC6 MCE
> > remotes, but also briefly with a Hauppauge RC5 remote, and all works
> > as expected.
> >
> > v2: fix call to ir_raw_event_handle so repeats work as they should.
>
> The driver seems ok, except for a few "magic" numbers.
>
> I'll apply at the tree, to allow more people to test. Please send me later
> a patch fixing those small issues.
I'll get something in flight tonight or tomorrow. All those uglies are in
the 1st-gen init code, which needs some further work anyway to kill off a
warning about the driver mapping memory from stack. I've got a number of
other 1st-gen tx and debug output fixes queued up as well.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2010-06-03 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 20:02 [PATCH 0/2] IR: add Windows MCE/eHome IR receiver driver Jarod Wilson
2010-05-28 20:03 ` [PATCH 1/2] IR: add RC6 keymap for Windows Media Center Ed. remotes Jarod Wilson
2010-06-01 20:30 ` [PATCH 1/2 v2] " Jarod Wilson
2010-05-28 20:05 ` [PATCH 2/2] IR: add mceusb IR receiver driver Jarod Wilson
2010-06-01 20:32 ` [PATCH 2/2 v2] " Jarod Wilson
2010-06-03 6:04 ` Mauro Carvalho Chehab
2010-06-03 22:10 ` Jarod Wilson [this message]
2010-06-04 4:11 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603221032.GD23375@redhat.com \
--to=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.