From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Kevin Hilman <khilman@deeprootsystems.com>
Cc: Charulatha V <charu@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"rnayak@ti.com" <rnayak@ti.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device
Date: Fri, 4 Jun 2010 09:05:58 +0300 [thread overview]
Message-ID: <20100604060558.GW11078@nokia.com> (raw)
In-Reply-To: <87aarcq6y6.fsf@deeprootsystems.com>
On Thu, Jun 03, 2010 at 08:58:25PM +0200, ext Kevin Hilman wrote:
>This doesn't look right for OMAP1. With a device name, you should
>just drop the "arm_cpio_ck" part, so you can do a clk_get(dev, NULL).
I guess it doesn't matter. clkdev will try to match device and clk
names, if that fails it will try device only and if that still fails,
clk only. Although I think something like "ick" instead of "arm_gpio_ck"
would be better.
And to decrease the amount of iterations to get the clock, use
clk_get(dev, "ick");
--
balbi
DefectiveByDesign.org
next prev parent reply other threads:[~2010-06-04 6:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 14:50 [PATCH 00/11] OMAP: GPIO: Implement GPIO in HWMOD way Charulatha V
2010-05-18 14:50 ` [PATCH 01/11] OMAP: GPIO: Modify init() in preparation for platform device implementation Charulatha V
2010-05-18 14:50 ` [PATCH 02/11] OMAP: GPIO: Include platform_data structure for GPIO Charulatha V
2010-05-18 14:50 ` [PATCH 03/11] OMAP: GPIO: Introduce support for OMAP15xx chip GPIO init Charulatha V
2010-05-18 14:50 ` [PATCH 04/11] OMAP: GPIO: Introduce support for OMAP16xx " Charulatha V
2010-05-18 14:50 ` [PATCH 05/11] OMAP: GPIO: Introduce support for OMAP7xx " Charulatha V
2010-05-18 14:50 ` [PATCH 06/11] OMAP: GPIO: add GPIO hwmods structures for OMAP3 Charulatha V
2010-05-18 14:50 ` [PATCH 07/11] OMAP: GPIO: add GPIO hwmods structures for OMAP242X Charulatha V
2010-05-18 14:50 ` [PATCH 08/11] OMAP: GPIO: add GPIO hwmods structures for OMAP243X Charulatha V
2010-05-18 14:50 ` [PATCH 09/11] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init Charulatha V
2010-05-18 14:50 ` [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device Charulatha V
2010-05-18 14:51 ` [PATCH 11/11] OMAP: GPIO: Remove omap_gpio_init() Charulatha V
[not found] ` <4BF2CD67.3090208@ti.com>
[not found] ` <EAF47CD23C76F840A9E7FCE10091EFAB02C5666252@dbde02.ent.ti.com>
2010-05-19 7:50 ` [PATCH 10/11] OMAP: GPIO: Implement GPIO as a platform device Cousson, Benoit
2010-05-20 16:36 ` Kevin Hilman
2010-06-03 18:58 ` Kevin Hilman
2010-06-04 6:05 ` Felipe Balbi [this message]
2010-05-18 23:46 ` [PATCH 09/11] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init Tony Lindgren
2010-05-19 7:26 ` Varadarajan, Charulatha
2010-06-03 18:36 ` Kevin Hilman
2010-06-03 18:31 ` [PATCH 07/11] OMAP: GPIO: add GPIO hwmods structures for OMAP242X Kevin Hilman
2010-06-03 18:30 ` [PATCH 06/11] OMAP: GPIO: add GPIO hwmods structures for OMAP3 Kevin Hilman
2010-05-18 23:41 ` [PATCH 01/11] OMAP: GPIO: Modify init() in preparation for platform device implementation Tony Lindgren
2010-05-19 7:23 ` Varadarajan, Charulatha
2010-05-19 8:01 ` Benoit Cousson
2010-05-19 13:57 ` Varadarajan, Charulatha
2010-05-19 15:32 ` Benoit Cousson
2010-05-18 23:42 ` [PATCH 00/11] OMAP: GPIO: Implement GPIO in HWMOD way Tony Lindgren
2010-05-19 7:30 ` Varadarajan, Charulatha
2010-06-03 18:21 ` Kevin Hilman
2010-05-19 8:54 ` Benoit Cousson
2010-05-19 13:55 ` Varadarajan, Charulatha
2010-05-19 15:24 ` Benoit Cousson
2010-06-03 18:46 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604060558.GW11078@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=charu@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.