From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: hp_sdc_rtc: fix broken ioctl conversion
Date: Sat, 5 Jun 2010 22:52:21 +0200 [thread overview]
Message-ID: <201006052252.21168.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTil7N3ZJclwotDQVt-8IYKudZ5mqPbyH906Cd4IJ@mail.gmail.com>
Commit 55929332c92 "drivers: Push down BKL into various drivers"
introduced a regression in hp_sdc_rtc, caused by a missing
change of the .unlocked_ioctl pointer to the newly introduced
function.
On Saturday 05 June 2010, Geert Uytterhoeven wrote:
> Something went wrong with this one:
>
> | drivers/input/misc/hp_sdc_rtc.c:681: warning: initialization from
> incompatible pointer type
> | drivers/input/misc/hp_sdc_rtc.c:665: warning:
> ‘hp_sdc_rtc_unlocked_ioctl’ defined but not used
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/input/misc/hp_sdc_rtc.c b/drivers/input/misc/hp_sdc_rtc.c
index e00a1cc..c190664 100644
--- a/drivers/input/misc/hp_sdc_rtc.c
+++ b/drivers/input/misc/hp_sdc_rtc.c
@@ -678,7 +678,7 @@ static const struct file_operations hp_sdc_rtc_fops = {
.llseek = no_llseek,
.read = hp_sdc_rtc_read,
.poll = hp_sdc_rtc_poll,
- .unlocked_ioctl = hp_sdc_rtc_ioctl,
+ .unlocked_ioctl = hp_sdc_rtc_unlocked_ioctl,
.open = hp_sdc_rtc_open,
.fasync = hp_sdc_rtc_fasync,
};
next prev parent reply other threads:[~2010-06-05 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201005241600.o4OG0QuA012887@hera.kernel.org>
2010-06-05 20:39 ` drivers: Push down BKL into various drivers Geert Uytterhoeven
2010-06-05 20:52 ` Arnd Bergmann [this message]
2010-06-05 21:01 ` hp_sdc_rtc: fix broken ioctl conversion Frederic Weisbecker
2010-06-06 11:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006052252.21168.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.