From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: stop using mpage_writepage
Date: Mon, 7 Jun 2010 12:03:44 +0200 [thread overview]
Message-ID: <20100607100344.GA1990@lst.de> (raw)
GFS2 always creates buffer_heads during ->write_begin or ->page_mkwrite,
which means mpage_writepage always falls back to block_write_full_page.
So stop calling mpage_writepage and always call block_write_full_page
directly.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/gfs2/aops.c
===================================================================
--- linux-2.6.orig/fs/gfs2/aops.c 2010-06-07 11:22:42.239273013 +0200
+++ linux-2.6/fs/gfs2/aops.c 2010-06-07 11:23:23.563255580 +0200
@@ -136,10 +136,7 @@ static int gfs2_writeback_writepage(stru
if (ret <= 0)
return ret;
- ret = mpage_writepage(page, gfs2_get_block_noalloc, wbc);
- if (ret == -EAGAIN)
- ret = block_write_full_page(page, gfs2_get_block_noalloc, wbc);
- return ret;
+ return block_write_full_page(page, gfs2_get_block_noalloc, wbc);
}
/**
next reply other threads:[~2010-06-07 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 10:03 Christoph Hellwig [this message]
2010-06-07 10:18 ` [Cluster-devel] [PATCH] gfs2: stop using mpage_writepage Steven Whitehouse
2010-06-07 16:19 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100607100344.GA1990@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.