From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ISL6271A voltage regulator support.
Date: Mon, 7 Jun 2010 16:54:51 +0200 [thread overview]
Message-ID: <201006071654.51324.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100607114856.GD5993@sirena.org.uk>
Dne Po 7. ?ervna 2010 13:48:56 Mark Brown napsal(a):
> On Mon, Jun 07, 2010 at 07:18:27AM +0200, Marek Vasut wrote:
> > This device is very simple, it supports only one LDO. This single LDO is
> > programmed over I2C to 16 possible voltages.
>
> Marek, you really should know to CC patches to maintainers by now. This
> is not CCed to myself, Liam or lkml.
I rather should have marked this RFC ... this code probably doesn't even work, I
just want someone who has zaurus to test it (they are CCed). Sorry for the
confusion.
>
> > +#include <linux/regulator/driver.h>
> > +#include <linux/regulator/machine.h>
>
> Why are you including machine.h here? I can't actually see any suspect
> code in the driver so I suspect it's unused.
>
> Otherwise this looks good.
next prev parent reply other threads:[~2010-06-07 14:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 5:18 [PATCH 1/2] ISL6271A voltage regulator support Marek Vasut
2010-06-07 5:18 ` [PATCH 2/2] pxa/spitz: Add isl6271a voltage regulator Marek Vasut
2010-06-07 5:28 ` [PATCH 1/2] ISL6271A voltage regulator support Marek Vasut
2010-06-07 11:48 ` Mark Brown
2010-06-07 14:54 ` Marek Vasut [this message]
2010-06-13 10:53 ` Eric Miao
-- strict thread matches above, loose matches on Subject: below --
2010-06-07 5:27 Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006071654.51324.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.