From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans
Date: Mon, 7 Jun 2010 20:41:40 +0300 [thread overview]
Message-ID: <20100607174140.GE11177@redhat.com> (raw)
In-Reply-To: <201006071742.56312.paul@codesourcery.com>
On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote:
> > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote:
> > > > With -netdev, there now seems to be little need to support vlans,
> > > > enabling them leads to user confusion and bad performance.
> > > > Disable support for vlans by default, add config option to enable.
> > >
> > > No. If you want to remove vlans, then actually do that.
> >
> > How is this not what this patch does? You mean kill the code
> > completely, not just --contigure option?
>
> Yes. Configure options are bad. If code isn't worth enabling by default then
> you've got to have a very good reason why it exists at all.
>
> Paul
Everyone ok with disabling vlans with no config option?
--
MST
next prev parent reply other threads:[~2010-06-07 18:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 15:03 [Qemu-devel] [PATCH] configure: add an option to disable vlans Michael S. Tsirkin
2010-06-07 16:16 ` Paul Brook
2010-06-07 16:17 ` Michael S. Tsirkin
2010-06-07 16:42 ` Paul Brook
2010-06-07 16:52 ` Anthony Liguori
2010-06-07 19:21 ` Michael S. Tsirkin
2010-06-07 20:40 ` Anthony Liguori
2010-06-07 20:58 ` Michael S. Tsirkin
2010-06-07 21:37 ` Anthony Liguori
2010-06-07 21:57 ` Anthony Liguori
2010-06-08 12:13 ` Michael S. Tsirkin
2010-06-08 13:03 ` Anthony Liguori
2010-06-08 13:07 ` Michael S. Tsirkin
2010-06-08 11:09 ` Michael S. Tsirkin
2010-06-08 13:02 ` Anthony Liguori
2010-06-08 13:14 ` Michael S. Tsirkin
2010-06-08 14:25 ` Gerd Hoffmann
2010-06-08 14:37 ` Paul Brook
2010-06-08 18:01 ` Anthony Liguori
2010-06-07 17:41 ` Michael S. Tsirkin [this message]
2010-06-09 7:44 ` Markus Armbruster
2010-06-10 7:20 ` Chris Webb
2010-06-10 8:43 ` Michael S. Tsirkin
2010-06-08 12:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100607174140.GE11177@redhat.com \
--to=mst@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.