All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@ftp.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH ver4] exofs: New truncate sequence
Date: Wed, 9 Jun 2010 15:55:12 +0200	[thread overview]
Message-ID: <20100609135512.GA26691@lst.de> (raw)
In-Reply-To: <4C0F7695.2020800@panasas.com>

> +	if (unlikely(ret)) {
> +		struct inode *inode = mapping->host;
> +		loff_t to = pos + len;
>  
> +		if (to > inode->i_size)
> +			truncate_pagecache(inode, to, inode->i_size);
> +	}

Might be worth to add a exofs_write_failed helper similar to ext2 that
can be shared with write_end, and once added ->direct_IO?

> +		error = inode_newsize_ok(inode, iattr->ia_size);
> +		if (unlikely(error))
> +			return error;

This has been folded into inode_change_ok in vfs.git #for_next, you
can drop it.


  parent reply	other threads:[~2010-06-09 13:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 22:22 [PATCH 47/58] convert exofs to ->evict_inode() Al Viro
2010-06-09  9:05 ` Boaz Harrosh
2010-06-09 10:02   ` Christoph Hellwig
2010-06-09 11:09     ` Boaz Harrosh
2010-06-09 11:10       ` [PATCH ver4] exofs: New truncate sequence Boaz Harrosh
2010-06-09 11:13         ` Boaz Harrosh
2010-06-09 12:45           ` Al Viro
2010-06-09 13:43             ` Boaz Harrosh
2010-06-09 21:46               ` Al Viro
2010-06-10 12:40                 ` Boaz Harrosh
2010-06-09 13:55         ` Christoph Hellwig [this message]
2010-06-09 15:26           ` Boaz Harrosh
2010-06-09 15:23         ` [PATCH ver5] " Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100609135512.GA26691@lst.de \
    --to=hch@lst.de \
    --cc=bharrosh@panasas.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.