All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eric Millbrandt <emillbrandt@dekaresearch.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Wolfgang Denk <wd@denx.de>
Subject: Re: [PATCH 0/2] mpc5200 ac97 gpio reset
Date: Wed, 9 Jun 2010 15:32:46 +0100	[thread overview]
Message-ID: <20100609143246.GA17945@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <0A40042D85E7C84DB443060EC44B3FD3253ECB8C84@dekaexchange07.deka.local>

On Wed, Jun 09, 2010 at 10:21:40AM -0400, Eric Millbrandt wrote:

[Please fix your MUA to word wrap paragraphs to within 80 characters,
I've reflowed the text below.]

> From the MPC5200B user manual:
> "Some AC97 devices goes to a test mode, if the Sync line is high
> during the Res line is low (reset phase). To avoid this behavior the
> Sync line must be also forced to zero during the reset phase. To do
> that, the pin muxing should switch to GPIO mode and the GPIO control
> register should be used to control the output lines."

Please include this quote in the changelog for the patch, if this a
documented workaround from the vendor that's a very different thing to
something that you've found happens to work on your systems (which is
more what your changelog sounded like).

  reply	other threads:[~2010-06-09 14:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 16:46 [PATCH 0/2] mpc5200 ac97 gpio reset Eric Millbrandt
2010-06-08 16:46 ` [PATCH 1/2] powerpc/5200: Export port-config Eric Millbrandt
2010-06-08 16:46   ` [PATCH 2/2] sound/soc: mpc5200_psc_ac97: Use gpio pins for cold reset Eric Millbrandt
2010-06-09 10:25     ` Mark Brown
2010-06-10 22:11   ` [PATCH 1/2] powerpc/5200: Export port-config Grant Likely
2010-06-09  0:24 ` [PATCH 0/2] mpc5200 ac97 gpio reset Jon Smirl
2010-06-09  6:13   ` Wolfgang Denk
2010-06-09 10:30     ` Mark Brown
2010-06-09 14:24       ` Eric Millbrandt
2010-06-10 22:07       ` Grant Likely
2010-06-10 23:14         ` Mark Brown
2010-06-10 23:31           ` Grant Likely
2010-06-09 12:21     ` Jon Smirl
2010-06-09 14:21       ` Eric Millbrandt
2010-06-09 14:32         ` Mark Brown [this message]
2010-06-09 14:41           ` Jon Smirl
2010-06-09 15:11             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100609143246.GA17945@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=emillbrandt@dekaresearch.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.