From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BE7BC1007D5 for ; Thu, 10 Jun 2010 01:11:28 +1000 (EST) Date: Wed, 9 Jun 2010 16:11:25 +0100 From: Mark Brown To: Jon Smirl Subject: Re: [PATCH 0/2] mpc5200 ac97 gpio reset Message-ID: <20100609151124.GB17945@opensource.wolfsonmicro.com> References: <1276015562-28928-1-git-send-email-emillbrandt@dekaresearch.com> <20100609061330.620AC14E867@gemini.denx.de> <0A40042D85E7C84DB443060EC44B3FD3253ECB8C84@dekaexchange07.deka.local> <20100609143246.GA17945@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: "linuxppc-dev@lists.ozlabs.org" , Eric Millbrandt , Wolfgang Denk List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 09, 2010 at 10:41:23AM -0400, Jon Smirl wrote: > On Wed, Jun 9, 2010 at 10:32 AM, Mark Brown > > Please include this quote in the changelog for the patch, if this a > > documented workaround from the vendor that's a very different thing to > > something that you've found happens to work on your systems (which is > > more what your changelog sounded like). > Mark, is there a way to ask the chip if it is in test mode? We need to > be sure that's whats happening and it isn't some other glitch. I'd need to work with the hardware teams to obtain this information, but I can confirm that having SYNC high while doing a reset is not supported and so fixing the driver to not do that is a good idea independantly of what it actually does to the chip.