From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 55/58] Make ->drop_inode() just return whether inode needs to be dropped Date: Wed, 9 Jun 2010 23:29:10 +0100 Message-ID: <20100609222910.GB31073@ZenIV.linux.org.uk> References: <30512.1276095957@jrobl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org To: "J. R. Okajima" Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:47787 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717Ab0FIW3N (ORCPT ); Wed, 9 Jun 2010 18:29:13 -0400 Content-Disposition: inline In-Reply-To: <30512.1276095957@jrobl> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 10, 2010 at 12:05:57AM +0900, J. R. Okajima wrote: > > Al Viro: > > diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c > > index e818f53..d32726d 100644 > > --- a/drivers/staging/pohmelfs/inode.c > > +++ b/drivers/staging/pohmelfs/inode.c > > @@ -1232,7 +1232,7 @@ static void pohmelfs_drop_inode(struct inode *inode) > > list_del_init(&pi->inode_entry); > > spin_unlock(&psb->ino_lock); > > > > - generic_drop_inode(inode); > > + return generic_drop_inode(inode); > > } > > The type of this function pohmelfs_drop_inode() should be converted too. Thanks, fixed.