From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56351 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OMUB9-0001bO-Ec
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 18:55:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OMUAx-00015K-P8
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 18:55:13 -0400
Received: from hall.aurel32.net ([88.191.82.174]:58734)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OMUAx-00015D-Hh
	for qemu-devel@nongnu.org; Wed, 09 Jun 2010 18:55:11 -0400
Date: Thu, 10 Jun 2010 00:55:09 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 05/35] tcg-s390: Icache flush is a no-op.
Message-ID: <20100609225509.GI3008@ohm.aurel32.net>
References: <1275678883-7082-1-git-send-email-rth@twiddle.net>
	<1275678883-7082-6-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1275678883-7082-6-git-send-email-rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, agraf@suse.de

On Fri, Jun 04, 2010 at 12:14:13PM -0700, Richard Henderson wrote:
> Before gcc 4.2, __builtin___clear_cache doesn't exist, and
> afterward the gcc s390 backend implements it as nothing.

Does it means that instruction and data caches are coherent on s390?

> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/s390/tcg-target.h |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/tcg/s390/tcg-target.h b/tcg/s390/tcg-target.h
> index d8a2955..d7fe0c7 100644
> --- a/tcg/s390/tcg-target.h
> +++ b/tcg/s390/tcg-target.h
> @@ -94,9 +94,4 @@ enum {
>  
>  static inline void flush_icache_range(unsigned long start, unsigned long stop)
>  {
> -#if QEMU_GNUC_PREREQ(4, 1)
> -    __builtin___clear_cache((char *) start, (char *) stop);
> -#else
> -#error not implemented
> -#endif
>  }
> -- 
> 1.7.0.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net