From: Milton Miller <miltonm@us.ibm.com>
To: Anton Blanchard <anton@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: rtas_flash cannot be a module
Date: Wed, 9 Jun 2010 16:01:10 +1000 [thread overview]
Message-ID: <20100610-reply@mdm.bga.com> (raw)
In-Reply-To: <20100609060110.GM28295@kryten>
On Wed, 9 Jun 2010 at about 16:01:10 +1000 Anton Blanchard wrote:
>
> When trying to flash a machine via the update_flash command, I received the
> following error:
>
>
> Restarting system.
> FLASH: kernel bug...flash list header addr above 4GB
>
>
> The code in question has a comment that the flash list should be in
> the kernel data and therefore under 4GB:
>
> /* NOTE: the "first" block list is a global var with no data
> * blocks in the kernel data segment. We do this because
> * we want to ensure this block_list addr is under 4GB.
> */
>
> Unfortunately the Kconfig option is marked tristate which means the variable
> may not be in the kernel data and could be above 4GB.
So we should use that rtas_data_buf with its lock ...
Oh look, the driver already uses that buffer for the call to verify_flash
untested patch to follow
milton
next prev parent reply other threads:[~2010-06-11 7:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 6:01 [PATCH] powerpc: rtas_flash cannot be a module Anton Blanchard
2010-06-09 6:01 ` Milton Miller [this message]
2010-06-09 6:01 ` [PATCH] powerpc: rtas_flash needs to use rtas_data_buf Milton Miller
2010-06-12 13:48 ` Anton Blanchard
2010-06-12 13:46 ` [PATCH] powerpc: rtas_flash cannot be a module Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610-reply@mdm.bga.com \
--to=miltonm@us.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.