From: Oleg Nesterov <oleg@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Nick Piggin <npiggin@suse.de>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [patch 06/18] oom: avoid sending exiting tasks a SIGKILL
Date: Thu, 10 Jun 2010 03:51:36 +0200 [thread overview]
Message-ID: <20100610015136.GA7595@redhat.com> (raw)
In-Reply-To: <20100610104309.f7559f31.kamezawa.hiroyu@jp.fujitsu.com>
On 06/10, KAMEZAWA Hiroyuki wrote:
>
> > Afaics
> >
> > - task_in_mem_cgroup() should use find_lock_task_mm() too
> >
> > - oom_kill_process() should check "PF_EXITING && p->mm",
> > like select_bad_process() does.
> >
>
> Hm. I'd like to look into that when the next mmotm is shipped.
> (too many pactches in flight..)
Me too ;)
> The problem is
>
> for (walking each 'process')
> if (task_in_mem_cgroup(p, memcg))
>
> can't check 'p' containes threads belongs to given memcg because p->mm can
> be NULL. So, task_in_mem_cgroup should call find_lock_task_mm() when
> getting "mm" struct.
Yes, this is what I meant. And after we do this change we should tweak
oom_kill_process() too, otherwise we have another problem.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-06-10 1:53 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 22:33 [patch 00/18] oom killer rewrite David Rientjes
2010-06-06 22:34 ` [patch 01/18] oom: check PF_KTHREAD instead of !mm to skip kthreads David Rientjes
2010-06-07 12:12 ` Balbir Singh
2010-06-07 19:50 ` David Rientjes
2010-06-08 19:33 ` Andrew Morton
2010-06-08 23:40 ` David Rientjes
2010-06-08 23:52 ` Andrew Morton
2010-06-06 22:34 ` [patch 02/18] oom: introduce find_lock_task_mm() to fix !mm false positives David Rientjes
2010-06-07 12:58 ` Balbir Singh
2010-06-07 13:49 ` Minchan Kim
2010-06-07 19:49 ` David Rientjes
2010-06-08 19:42 ` Andrew Morton
2010-06-08 20:14 ` Oleg Nesterov
2010-06-08 20:17 ` Oleg Nesterov
2010-06-08 21:34 ` Andrew Morton
2010-06-08 23:50 ` David Rientjes
2010-06-06 22:34 ` [patch 03/18] oom: dump_tasks use find_lock_task_mm too David Rientjes
2010-06-08 19:55 ` Andrew Morton
2010-06-09 0:06 ` David Rientjes
2010-06-06 22:34 ` [patch 04/18] oom: PF_EXITING check should take mm into account David Rientjes
2010-06-08 20:00 ` Andrew Morton
2010-06-06 22:34 ` [patch 05/18] oom: give current access to memory reserves if it has been killed David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:47 ` David Rientjes
2010-06-14 11:08 ` KOSAKI Motohiro
2010-06-08 20:12 ` Andrew Morton
2010-06-13 11:24 ` KOSAKI Motohiro
2010-06-08 20:08 ` Andrew Morton
2010-06-09 0:14 ` David Rientjes
2010-06-06 22:34 ` [patch 06/18] oom: avoid sending exiting tasks a SIGKILL David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:48 ` David Rientjes
2010-06-08 20:17 ` Andrew Morton
2010-06-08 20:26 ` Oleg Nesterov
2010-06-09 6:32 ` David Rientjes
2010-06-09 16:25 ` Oleg Nesterov
2010-06-09 19:44 ` David Rientjes
2010-06-09 20:14 ` Oleg Nesterov
2010-06-10 0:15 ` KAMEZAWA Hiroyuki
2010-06-10 1:21 ` Oleg Nesterov
2010-06-10 1:43 ` KAMEZAWA Hiroyuki
2010-06-10 1:51 ` Oleg Nesterov [this message]
2010-06-06 22:34 ` [patch 07/18] oom: filter tasks not sharing the same cpuset David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:51 ` David Rientjes
2010-06-08 19:27 ` Andrew Morton
2010-06-13 11:24 ` KOSAKI Motohiro
2010-07-02 22:35 ` Andrew Morton
2010-07-04 22:08 ` David Rientjes
2010-07-09 3:00 ` KOSAKI Motohiro
2010-06-08 20:23 ` Andrew Morton
2010-06-09 0:25 ` David Rientjes
2010-06-06 22:34 ` [patch 08/18] oom: sacrifice child with highest badness score for parent David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 18:53 ` David Rientjes
2010-06-08 20:33 ` Andrew Morton
2010-06-09 0:30 ` David Rientjes
2010-06-06 22:34 ` [patch 09/18] oom: select task from tasklist for mempolicy ooms David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 21:08 ` Andrew Morton
2010-06-08 21:17 ` Oleg Nesterov
2010-06-09 0:46 ` David Rientjes
2010-06-08 23:43 ` Andrew Morton
2010-06-09 0:40 ` David Rientjes
2010-06-06 22:34 ` [patch 10/18] oom: enable oom tasklist dump by default David Rientjes
2010-06-08 11:42 ` KOSAKI Motohiro
2010-06-08 18:56 ` David Rientjes
2010-06-08 21:13 ` Andrew Morton
2010-06-09 0:52 ` David Rientjes
2010-06-06 22:34 ` [patch 11/18] oom: avoid oom killer for lowmem allocations David Rientjes
2010-06-08 11:42 ` KOSAKI Motohiro
2010-06-08 21:19 ` Andrew Morton
2010-06-06 22:34 ` [patch 12/18] oom: extract panic helper function David Rientjes
2010-06-08 11:42 ` KOSAKI Motohiro
2010-06-06 22:34 ` [patch 13/18] oom: remove special handling for pagefault ooms David Rientjes
2010-06-08 11:42 ` KOSAKI Motohiro
2010-06-08 18:57 ` David Rientjes
2010-06-08 21:27 ` Andrew Morton
2010-06-06 22:34 ` [patch 14/18] oom: move sysctl declarations to oom.h David Rientjes
2010-06-08 11:42 ` KOSAKI Motohiro
2010-06-06 22:34 ` [patch 15/18] oom: remove unnecessary code and cleanup David Rientjes
2010-06-06 22:34 ` [patch 16/18] oom: badness heuristic rewrite David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 23:02 ` Andrew Morton
2010-06-13 11:24 ` KOSAKI Motohiro
2010-06-17 5:14 ` David Rientjes
2010-06-21 11:45 ` KOSAKI Motohiro
2010-06-21 20:47 ` David Rientjes
2010-06-30 9:26 ` KOSAKI Motohiro
2010-06-17 5:12 ` David Rientjes
2010-06-21 11:45 ` KOSAKI Motohiro
2010-06-08 22:58 ` Andrew Morton
2010-06-17 5:32 ` David Rientjes
2010-06-06 22:34 ` [patch 17/18] oom: add forkbomb penalty to badness heuristic David Rientjes
2010-06-08 11:41 ` KOSAKI Motohiro
2010-06-08 23:15 ` Andrew Morton
2010-06-06 22:35 ` [patch 18/18] oom: deprecate oom_adj tunable David Rientjes
2010-06-08 11:42 ` KOSAKI Motohiro
2010-06-08 19:00 ` David Rientjes
2010-06-08 23:18 ` Andrew Morton
2010-06-13 11:24 ` KOSAKI Motohiro
2010-06-17 3:36 ` David Rientjes
2010-06-21 11:45 ` KOSAKI Motohiro
2010-06-21 20:54 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610015136.GA7595@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.