From: Tony Lindgren <tony@atomide.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: linux-omap@vger.kernel.org, Matt Fleming <matt@console-pimps.org>
Subject: Re: [PATCH] omap_hsmmc: Remove unused state variable
Date: Thu, 10 Jun 2010 09:49:00 +0300 [thread overview]
Message-ID: <20100610064900.GQ32208@atomide.com> (raw)
In-Reply-To: <1276029700-27900-1-git-send-email-saaguirre@ti.com>
* Sergio Aguirre <saaguirre@ti.com> [100608 23:35]:
> This fixes the following warning:
>
> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
> drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state'
>
> Introduced by commit ID:
>
> commit 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e
> Author: Matt Fleming <matt@console-pimps.org>
> Date: Wed May 26 14:42:08 2010 -0700
>
> mmc: remove the "state" argument to mmc_suspend_host()
>
> The unique usage of this var was removed there, and missed
> removing the respective declaration aswell.
This should be sent to linux-mmc list.
Tony
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index b032828..d50e917 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev)
> int ret = 0;
> struct platform_device *pdev = to_platform_device(dev);
> struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
> - pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
>
> if (host && host->suspended)
> return 0;
> --
> 1.6.3.3
>
next prev parent reply other threads:[~2010-06-10 6:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 20:41 [PATCH] omap_hsmmc: Remove unused state variable Sergio Aguirre
2010-06-08 21:57 ` Matt Fleming
2010-06-10 6:49 ` Tony Lindgren [this message]
2010-06-10 13:45 ` Aguirre, Sergio
-- strict thread matches above, loose matches on Subject: below --
2010-06-10 14:00 Sergio Aguirre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610064900.GQ32208@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=saaguirre@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.