From: Christoph Hellwig <hch@lst.de>
To: Nick Piggin <npiggin@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
mfasheh@suse.de
Subject: Re: [PATCH 2/2] check ATTR_SIZE contraints in inode_change_ok
Date: Thu, 10 Jun 2010 10:21:41 +0200 [thread overview]
Message-ID: <20100610082140.GA2039@lst.de> (raw)
In-Reply-To: <20100609102623.GB26335@laptop>
On Wed, Jun 09, 2010 at 08:26:23PM +1000, Nick Piggin wrote:
> What about network filesystems? Some (ceph, cifs) seem to do i_size
> checks under i_lock.
Hmm, If we don't get that sorted we need to split out the current
inode_change_ok into __inode_change_ok. Then again these filesystems
will also need locking for the other attributes. I'll do another
audit for these.
next prev parent reply other threads:[~2010-06-10 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 11:39 [PATCH 0/2] new truncate sequence, part3 Christoph Hellwig
2010-06-01 11:39 ` [PATCH 1/2] always call inode_change_ok early in ->setattr Christoph Hellwig
2010-06-01 11:39 ` [PATCH 2/2] check ATTR_SIZE contraints in inode_change_ok Christoph Hellwig
2010-06-01 11:49 ` Steven Whitehouse
2010-06-01 11:47 ` Christoph Hellwig
2010-06-09 7:33 ` Nick Piggin
2010-06-09 9:41 ` Jan Kara
2010-06-09 10:06 ` Nick Piggin
2010-06-09 10:07 ` Christoph Hellwig
2010-06-09 10:26 ` Nick Piggin
2010-06-10 8:21 ` Christoph Hellwig [this message]
2010-06-09 10:59 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610082140.GA2039@lst.de \
--to=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.de \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.