From: Tony Lindgren <tony@atomide.com>
To: Govindraj <govindraj.ti@gmail.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
"Govindraj.R" <govindraj.raja@ti.com>,
linux-omap@vger.kernel.org, Sergio Aguirre <saaguirre@ti.com>
Subject: Re: [pm-wip/uart][PATCH 2/4] OMAP3: serial: Fix uart4 handling for 3630
Date: Thu, 10 Jun 2010 14:12:17 +0300 [thread overview]
Message-ID: <20100610111217.GA32208@atomide.com> (raw)
In-Reply-To: <AANLkTimSZaqZbP84C35dKh5XVZxezo-54ihxkpNx_Dni@mail.gmail.com>
* Govindraj <govindraj.ti@gmail.com> [100610 11:49]:
>
> -> Shouldn't we just retrieve the offset and then use
> omap_ctrl_writew\ omap_ctrl_readw calls?
Sure that works too. And that actually has the advantage
that it's more likely to keep the mux read/write access
in the platform init code.
> -> I hope muxmode configuration can be done in the
> existing code itself by manually populating the mode
> and use offset retrieved from omap_mux_request_signal
> and use omap_ctrl_writew.
> Any comment?
I'm not sure I follow you, but you should keep any mux
functions in the platform init code and keep the driver
as generic as possible.
Regards,
Tony
prev parent reply other threads:[~2010-06-10 11:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 13:43 [pm-wip/uart][PATCH 2/4] OMAP3: serial: Fix uart4 handling for 3630 Govindraj.R
2010-06-04 14:03 ` Gopinath, Thara
2010-06-04 14:08 ` Govindraj
2010-06-04 15:35 ` Kevin Hilman
2010-06-07 8:47 ` Govindraj
2010-06-07 10:06 ` Tony Lindgren
2010-06-07 11:32 ` Govindraj
2010-06-07 14:56 ` Govindraj
2010-06-09 14:28 ` Tony Lindgren
2010-06-10 8:54 ` Govindraj
2010-06-10 11:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100610111217.GA32208@atomide.com \
--to=tony@atomide.com \
--cc=govindraj.raja@ti.com \
--cc=govindraj.ti@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=saaguirre@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.