From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 12/20] stkutil: Add the Call Control envelope builder
Date: Fri, 11 Jun 2010 14:34:35 -0500 [thread overview]
Message-ID: <201006111434.35867.denkenz@gmail.com> (raw)
In-Reply-To: <AANLkTincE0TeBlPw8gnaNmOoRMK46USpW3XBHZ0aNWU6@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
Hi Andrew,
> >> +/* Used both in the ENVELOPE message to UICC and response from UICC */
> >> +struct stk_envelope_call_control {
> >> + /* Exactly one of the following 5 fields must be present */
> >
> > Why are we not using a union then?
>
> We don't know which one of 5 is valid if it's a union. We could add a
> field to indicate that but I guess it's simpler the way it is.
It seems like a type + union might be better for the consumers of this
structure though. Otherwise they have to check up to 5 structs for emptiness
before figuring out what the type actually is. Your call.
Regards,
-Denis
next prev parent reply other threads:[~2010-06-11 19:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 10:08 [PATCH 01/20] Make stk_pdu_from_response use static buffers Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 02/20] stkutil: Add SMS-PP Data Download envelope builder Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 03/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 04/20] stkutil: Add CBS-PP " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 05/20] stk: Use envelope encoding utility from stkutil.c Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 06/20] Fix: download CBS to SIM even when "Powered" is 0 Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 07/20] test-stkutil: Tests for CBS-PP Data Download envelope builder Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 08/20] stkutil: Add the Menu Selection " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 09/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 10/20] Add a "sim string" encoding utility Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 11/20] simutil: Fix MMC MNC encoding for 2-digit MNCs Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 12/20] stkutil: Add the Call Control envelope builder Andrzej Zaborowski
2010-06-09 22:57 ` Denis Kenzior
2010-06-11 19:18 ` Andrzej Zaborowski
2010-06-11 19:34 ` Denis Kenzior [this message]
2010-06-11 20:04 ` Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 13/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 14/20] stkutil: Add the MO Short Message " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 15/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 16/20] For unitialised stk_location_info emit no data object Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 17/20] stkutil: Add the Event Download envelope builder Andrzej Zaborowski
2010-06-10 1:06 ` Denis Kenzior
2010-06-10 1:19 ` Marcel Holtmann
2010-06-10 1:37 ` Denis Kenzior
2010-06-11 19:27 ` Andrzej Zaborowski
2010-06-11 19:31 ` Denis Kenzior
2010-06-07 10:08 ` [PATCH 18/20] test-stkutil: Tests for " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 19/20] stkutil: Add the Timer Expiration " Andrzej Zaborowski
2010-06-07 10:08 ` [PATCH 20/20] test-stkutil: Tests for " Andrzej Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006111434.35867.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.