From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] apic: clean up msr handling Date: Fri, 11 Jun 2010 18:10:20 +0200 Message-ID: <201006111810.20689.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Friday 11 June 2010 17:57:58 Keir Fraser wrote: > On 11/06/2010 16:51, "Christoph Egger" wrote: > >> Hm, I didn't spot that one. It's odd since I thought Christoph was > >> changign macros into inlien functions where possible. Maybe he just > >> changes in whichever direction makes his patch bigger? ;-) > > > > No, this change has to do with 'smp_processor_id() undefined'. > > The root problem is a circular dependency with inclusion of headers. > > The right fix is to clean up the headers. > > Yep, that's what I did. Yes, I saw that in c/s 21605. Thanks for doing this. But this is not what I meant by 'clean up the headers'. For example, when you do touch xen/include/asm-x86/apic.h then in the next build files that have nothing to do with apic get recompiled because apic.h is indirectly included. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632