From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35958 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ONSpA-0004QO-9J
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 11:40:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1ONSp8-0006MF-Of
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 11:40:44 -0400
Received: from hall.aurel32.net ([88.191.82.174]:48539)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1ONSp8-0006Lt-KN
	for qemu-devel@nongnu.org; Sat, 12 Jun 2010 11:40:42 -0400
Date: Sat, 12 Jun 2010 16:37:58 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] configure: Fix evaluation of
	config-host.mak in create_config
Message-ID: <20100612143758.GD1940@ohm.aurel32.net>
References: <4C12A375.6050201@web.de> <20100612115557.GK3008@ohm.aurel32.net>
	<4C137CA6.1020808@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4C137CA6.1020808@web.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote:
> Aurelien Jarno wrote:
> > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Only match on true dir variable assignments, avoid generating garbage
> >> due to the "# Configured with: ..." line which may contain "*dir=" as
> >> well.
> > 
> > Wouldn't it be better to skip all lines starting with '#', as this
> > problem might happen again after some more changes?
> > 
> > Or maybe we should do both.
> 
> This is what the patch (implicitly) does.

Yes, but only for this line. What I mean is something more generic
like:

"#"*) # comment
    continue
    ;;

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net