All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Divyesh Shah <dpshah@google.com>
Cc: jaxboe@fusionio.com, peterz@infradead.org, piotr@hosowicz.com,
	linux-kernel@vger.kernel.org, vgoyal@redhat.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] Remove preempt_enable/disable calls around sched_clock()
Date: Sun, 13 Jun 2010 12:01:21 +0200	[thread overview]
Message-ID: <20100613100121.GC12322@elte.hu> (raw)
In-Reply-To: <AANLkTimcB3Jzb0b9pw5YOs5qmeznlcNFOqm64TBqOEdr@mail.gmail.com>


* Divyesh Shah <dpshah@google.com> wrote:

> On Sat, Jun 12, 2010 at 12:19 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Divyesh Shah <dpshah@google.com> wrote:
> >
> >> calls in the block layer. This was a temporary fix added.
> >
> > Not good, this commit reintroduces those ugly warnings, if someone happens to
> > bisect straight into this commit.
> 
> You're right. In the next version, I'll merge both patches into one so
> this cannot happen.

Yeah - or if you really want to make a point of doing the two things in two 
separate patches you can first fix the API, _then_ remove the preemption 
enable/disable.

Thanks,

	Ingo

      reply	other threads:[~2010-06-13 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-12  2:34 [PATCH 1/2] Remove preempt_enable/disable calls around sched_clock() Divyesh Shah
2010-06-12  2:35 ` [PATCH 2/2] Use ktime_get() instead of sched_clock() for blkio cgroup stats Divyesh Shah
2010-06-12  7:18   ` Ingo Molnar
2010-06-12 15:51     ` Divyesh Shah
2010-06-12  7:19 ` [PATCH 1/2] Remove preempt_enable/disable calls around sched_clock() Ingo Molnar
2010-06-12 15:52   ` Divyesh Shah
2010-06-13 10:01     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100613100121.GC12322@elte.hu \
    --to=mingo@elte.hu \
    --cc=dpshah@google.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=piotr@hosowicz.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.