From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios.
Date: Sun, 13 Jun 2010 20:55:23 +0100 [thread overview]
Message-ID: <201006132055.24141.paul@codesourcery.com> (raw)
In-Reply-To: <20100613171915.GA13238@redhat.com>
> > And I think we can move the capability setup into init. But this is not
> > directly related to this patch, would just avoid adding this hunk to
> > hpet_reset.
>
> I actually did that initially and tried to init hpet_cfg there too, but
> then noticed that mmio[0].addr below is not initialized at init time yet.
>
> > > + hpet_cfg.hpet.address = sysbus_from_qdev(d)->mmio[0].addr;
This is one of the reasons that you're not supposed to be messing with
DeviceState contents directly.
Paul
next prev parent reply other threads:[~2010-06-13 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 14:43 [Qemu-devel] [PATCH] pass info about hpets to seabios Gleb Natapov
2010-06-13 16:56 ` [Qemu-devel] " Jan Kiszka
2010-06-13 17:19 ` Gleb Natapov
2010-06-13 17:41 ` Jan Kiszka
2010-06-13 19:02 ` Gleb Natapov
2010-06-13 19:55 ` Paul Brook [this message]
2010-06-14 5:18 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006132055.24141.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.