From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] PATCH [1/1] fix building QT with uclibc 0.9.31
Date: Mon, 14 Jun 2010 10:25:04 +0200 [thread overview]
Message-ID: <20100614102504.4ba36304@surf> (raw)
In-Reply-To: <AC75A538105F448E979110FFB6C1D3B9@apexjs>
Hello Sagaert,
Your patch is unfortunately word-wrapped. Can you configure your e-mail
client not to word-wrap patches ?
Moreover, this patch needs a description: what is it fixing ?
Thanks!
Thomas
On Mon, 14 Jun 2010 10:19:45 +0200
"Sagaert Johan" <sagaert.johan@skynet.be> wrote:
> diff -rupN
> buildroot-2010.05/package/qt/qt-4.6.2-pthread_getattr_np.patch
> buildroot/package/qt/qt-4.6.2-pthread_getattr_np.patch ---
> buildroot-2010.05/package/qt/qt-4.6.2-pthread_getattr_np.patch
> 1970-01-01 01:00:00.000000000 +0100 +++
> buildroot/package/qt/qt-4.6.2-pthread_getattr_np.patch 2010-06-13
> 19:10:16.000000000 +0200 @@ -0,0 +1,104 @@
> +---
> qt-everywhere-opensource-src-4.6.2/src/3rdparty/javascriptcore/JavaScriptCor
> e/runtime/Collector.cpp 2010-02-11 16:55:20.000000000 +0100
> ++++
> qt-everywhere-opensource-src-4.6.2JS/src/3rdparty/javascriptcore/JavaScriptC
> ore/runtime/Collector.cpp 2010-05-23 10:49:29.000000000 +0200
> +@@ -74,6 +74,22 @@
> + #endif
> + #include <unistd.h>
> +
> ++#if defined(QT_LINUXBASE)
> ++#include <dlfcn.h>
> ++#endif
> ++
> ++#if defined(__UCLIBC__)
> ++// versions of uClibc 0.9.28 and below do not have
> ++// pthread_getattr_np or pthread_attr_getstack.
> ++#if __UCLIBC_MAJOR__ == 0 && \
> ++ (__UCLIBC_MINOR__ < 9 || \
> ++ (__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ <= 31))
> ++#define UCLIBC_USE_PROC_SELF_MAPS 1
> ++#include <stdio_ext.h>
> ++extern int *__libc_stack_end;
> ++#endif
> ++#endif
> ++
> + #if PLATFORM(SOLARIS)
> + #include <thread.h>
> + #else
> +@@ -667,16 +683,59 @@ static inline void* currentThreadStackBa
> + get_thread_info(find_thread(NULL), &threadInfo);
> + return threadInfo.stack_end;
> + #elif PLATFORM(UNIX)
> ++#ifdef UCLIBC_USE_PROC_SELF_MAPS
> ++ // Read /proc/self/maps and locate the line whose address
> ++ // range contains __libc_stack_end.
> ++ FILE *file = fopen("/proc/self/maps", "r");
> ++ if (!file)
> ++ return 0;
> ++ __fsetlocking(file, FSETLOCKING_BYCALLER);
> ++ char *line = NULL;
> ++ size_t lineLen = 0;
> ++ while (!feof_unlocked(file)) {
> ++ if (getdelim(&line, &lineLen, '\n', file) <= 0)
> ++ break;
> ++
> ++ long from;
> ++ long to;
> ++ if (sscanf (line, "%lx-%lx", &from, &to) != 2)
> ++ continue;
> ++ if (from <= (long)__libc_stack_end &&
> (long)__libc_stack_end < to) {
> ++ fclose(file);
> ++ free(line);
> ++#ifdef _STACK_GROWS_UP
> ++ return (void *)from;
> ++#else
> ++ return (void *)to;
> ++#endif
> ++ }
> ++ }
> ++ fclose(file);
> ++ free(line);
> ++ return 0;
> ++ #else
> + static void* stackBase = 0;
> + static size_t stackSize = 0;
> + static pthread_t stackThread;
> + pthread_t thread = pthread_self();
> + if (stackBase == 0 || thread != stackThread) {
> ++
> ++#if defined(QT_LINUXBASE)
> ++ // LinuxBase is missing pthread_getattr_np - resolve it
> once at runtime instead
> ++ // see http://bugs.linuxbase.org/show_bug.cgi?id=2364
> ++ typedef int (*GetAttrPtr)(pthread_t, pthread_attr_t *);
> ++ static int (*pthread_getattr_np_ptr)(pthread_t,
> pthread_attr_t *) = 0;
> ++ if (!pthread_getattr_np_ptr)
> ++ *(void **)&pthread_getattr_np_ptr = dlsym(RTLD_DEFAULT,
> "pthread_getattr_np");
> ++#endif
> + pthread_attr_t sattr;
> + pthread_attr_init(&sattr);
> + #if HAVE(PTHREAD_NP_H) || PLATFORM(NETBSD)
> + // e.g. on FreeBSD 5.4, neundorf at kde.org
> + pthread_attr_get_np(thread, &sattr);
> ++#elif defined(QT_LINUXBASE)
> ++ if (pthread_getattr_np_ptr)
> ++ pthread_getattr_np_ptr(thread, &sattr);
> + #else
> + // FIXME: this function is non-portable; other POSIX
> systems may have different np alternatives
> + pthread_getattr_np(thread, &sattr);
> +@@ -688,6 +747,7 @@ static inline void* currentThreadStackBa
> + stackThread = thread;
> + }
> + return static_cast<char*>(stackBase) + stackSize;
> ++#endif
> + #elif PLATFORM(WINCE)
> + if (g_stackBase)
> + return g_stackBase;
> +---
> qt-everywhere-opensource-src-4.6.2/src/3rdparty/webkit/JavaScriptCore/runtim
> e/Collector.cpp 2010-02-11 16:55:17.000000000 +0100
> ++++
> qt-everywhere-opensource-src-4.6.2JS/src/3rdparty/webkit/JavaScriptCore/runt
> ime/Collector.cpp 2010-05-23 01:41:06.000000000 +0200
> +@@ -83,7 +83,7 @@
> + // pthread_getattr_np or pthread_attr_getstack.
> + #if __UCLIBC_MAJOR__ == 0 && \
> + (__UCLIBC_MINOR__ < 9 || \
> +- (__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ <= 30))
> ++ (__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ <= 31))
> + #define UCLIBC_USE_PROC_SELF_MAPS 1
> + #include <stdio_ext.h>
> + extern int *__libc_stack_end;
>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-06-14 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:19 [Buildroot] PATCH [1/1] fix building QT with uclibc 0.9.31 Sagaert Johan
2010-06-14 8:25 ` Thomas Petazzoni [this message]
2010-06-14 8:35 ` Peter Korsgaard
2010-06-14 10:10 ` Sagaert Johan
2010-06-15 8:59 ` Peter Korsgaard
2010-06-15 9:54 ` Sagaert Johan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614102504.4ba36304@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.