All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.de>
To: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [RFC] [PATCH] Adding support for BMP085 pressure sensor.
Date: Mon, 14 Jun 2010 12:30:56 +0200	[thread overview]
Message-ID: <201006141230.56099.oneukum@suse.de> (raw)
In-Reply-To: <0680EC522D0CC943BC586913CF3768C003B34A60A3@dbde02.ent.ti.com>

Am Montag, 14. Juni 2010 12:13:44 schrieb Datta, Shubhrajyoti:

> +/* sysfs callbacks */
> +static ssize_t set_oversampling(struct device *dev,
> +				struct device_attribute *attr,
> +				const char *buf,
> +				size_t count)
> +{
> +	struct i2c_client *client = to_i2c_client(dev);
> +	struct bmp085_data *data = i2c_get_clientdata(client);
> +	data->oversampling_setting = simple_strtoul(buf, NULL, 10);
> +	if (data->oversampling_setting > 3)
> +		data->oversampling_setting = 3;
> +	return count;
> +}

What happens if somebody writes a non-numerical value?

	Regards
		Oliver

  parent reply	other threads:[~2010-06-14 10:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-14 10:13 [RFC] [PATCH] Adding support for BMP085 pressure sensor Datta, Shubhrajyoti
2010-06-14 10:16 ` Oliver Neukum
2010-06-14 10:30 ` Oliver Neukum [this message]
2010-06-14 10:35 ` Stefan Schmidt
2010-06-14 10:58   ` Christoph Mair
2010-06-14 10:59   ` Datta, Shubhrajyoti
2010-06-14 11:55 ` J.I. Cameron
2010-06-14 14:14   ` Datta, Shubhrajyoti
  -- strict thread matches above, loose matches on Subject: below --
2010-06-14 14:19 Datta, Shubhrajyoti
2010-06-14 16:44 ` Jonathan Cameron
2010-06-14 16:44 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006141230.56099.oneukum@suse.de \
    --to=oneukum@suse.de \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.