All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ISL6271A voltage regulator support.
Date: Mon, 14 Jun 2010 13:48:31 +0100	[thread overview]
Message-ID: <20100614124831.GE14604@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1276442751-3562-1-git-send-email-marek.vasut@gmail.com>

On Sun, Jun 13, 2010 at 05:25:51PM +0200, Marek Vasut wrote:
> This device is very simple, it supports one buck and two LDOs. The LDOs are
> fixed-voltage. Only the buck is programable over the I2C bus to 16 possible
> voltages.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

For future reference...

> +	/* Convert the data from chip to microvolts */
> +	data = ISL6271A_VOLTAGE_MIN + (ISL6271A_VOLTAGE_STEP * (idx & 0xf));

...note that this is just list_voltage() (if you're going to fix this
please only do so with an incremental patch).

  reply	other threads:[~2010-06-14 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-13 15:25 [PATCH v3] ISL6271A voltage regulator support Marek Vasut
2010-06-14 12:48 ` Mark Brown [this message]
2010-06-15 10:47   ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100614124831.GE14604@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.