From: Dan Carpenter <error27@gmail.com>
To: Abhijeet Joglekar <abjoglek@cisco.com>
Cc: Joe Eykholt <jeykholt@cisco.com>, linux-scsi@vger.kernel.org
Subject: smatch stuff: fnic: VNIC_FNIC_EDTOV_MAX is too high.
Date: Mon, 14 Jun 2010 14:52:25 +0200 [thread overview]
Message-ID: <20100614125225.GW5483@bicker> (raw)
This is a smatch thing. Neither VNIC_FNIC_EDTOV_MAX nor
VNIC_FNIC_RATOV_MAX do anything. They are both set to 255000 but ed_tov
and ra_tov are u16 so they can't go higher than 65535.
drivers/scsi/fnic/fnic_res.c
95 c->ed_tov =
96 min_t(u32, VNIC_FNIC_EDTOV_MAX,
97 max_t(u32, VNIC_FNIC_EDTOV_MIN,
98 c->ed_tov));
99
100 c->ra_tov =
101 min_t(u32, VNIC_FNIC_RATOV_MAX,
102 max_t(u32, VNIC_FNIC_RATOV_MIN,
103 c->ra_tov));
regards,
dan carpenter
reply other threads:[~2010-06-14 12:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614125225.GW5483@bicker \
--to=error27@gmail.com \
--cc=abjoglek@cisco.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.