From: tytso@mit.edu
To: Johannes Stezenbach <js@sig21.net>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: FIGETBSZ ioctl conflict
Date: Mon, 14 Jun 2010 09:42:52 -0400 [thread overview]
Message-ID: <20100614134252.GA22163@thunk.org> (raw)
In-Reply-To: <20100614123652.GA312@sig21.net>
On Mon, Jun 14, 2010 at 02:36:52PM +0200, Johannes Stezenbach wrote:
> (forgot to add lkml to Cc)
>
> On Mon, Jun 14, 2010 at 01:02:52PM +0200, Johannes Stezenbach wrote:
> > Hi,
> >
> > in commit 19ba0559 the FIGETBSZ (and FS_IOC_FIEMAP) ioctl was moved
> > from file_ioctl() to do_vfs_ioctl(), so it also works for directories.
> > The problem I'm seeing is that FIGETBSZ is defined as _IO(0x00,2)
> > which is simply 2. so there is some potential for conflicts
> > with character devices which do not use the _IO macros for numbering
> > their ioctls.
> > Just doing a web search for "FIGETBSZ ioctl conflict" shows
> > that a few people already ran into this problem.
> >
> > Would you mind adding a check for S_ISDIR | S_ISREG,
> > or maybe !S_ISCHR?
Yeah, I think the right thing to do here is a check for
S_ISDIR | S_ISREG | S_ISLNK.
- Ted
next prev parent reply other threads:[~2010-06-14 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100614110252.GB32224@sig21.net>
2010-06-14 12:36 ` FIGETBSZ ioctl conflict Johannes Stezenbach
2010-06-14 13:42 ` tytso [this message]
2010-06-14 14:05 ` [PATCH] Only honor the FIGETBSZ ioctl for regular files, directories, and symlinks Theodore Ts'o
2010-06-14 14:07 ` Christoph Hellwig
2010-06-14 14:12 ` tytso
2010-06-14 14:15 ` [PATCH -v2] Only honor the FIGETBSZ ioctl for regular files and directories Theodore Ts'o
2010-06-14 14:17 ` [PATCH -v3] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614134252.GA22163@thunk.org \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=js@sig21.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.