From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: john.r.fastabend@intel.com, markus@trippelsdorf.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
yanmin_zhang@linux.intel.com, alex.shi@intel.com,
tim.c.chen@intel.com
Subject: Re: mpd client timeouts (bisected) 2.6.35-rc3
Date: Mon, 14 Jun 2010 17:13:13 +0300 [thread overview]
Message-ID: <20100614141313.GB25547@redhat.com> (raw)
In-Reply-To: <20100613.171318.193707256.davem@davemloft.net>
On Sun, Jun 13, 2010 at 05:13:18PM -0700, David Miller wrote:
> From: John Fastabend <john.r.fastabend@intel.com>
> Date: Sun, 13 Jun 2010 13:36:30 -0700
>
> > Needed to set the wcard bit in copy_skb_header otherwise it will not
> > be cleared when called from skb_clone. Which then hits the loopback
> > device gets pushed into the rx path and is eventually dropped. The
> > following patch fixes this. Hopefully, this is easy and fast enough
> > for you Dave.
> >
> >
> > [PATCH] net: fix deliver_no_wcard regression on loopback device
> >
> > deliver_no_wcard is not being set in skb_copy_header.
> > In the skb_cloned case it is not being cleared and
> > may cause the skb to be dropped when the loopback device
> > pushes it back up the stack.
> >
> > Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>
> Applied, but your email client corrupted this patch in many
> ways. Please correct this for next time, thanks.
FWIW:
Tested-by: Michael S. Tsirkin <mst@redhat.com>
--
MST
next prev parent reply other threads:[~2010-06-14 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 10:28 mpd client timeouts (bisected) 2.6.35-rc3 Markus Trippelsdorf
2010-06-12 21:58 ` David Miller
2010-06-13 8:05 ` John Fastabend
2010-06-13 20:36 ` John Fastabend
2010-06-13 20:50 ` Eric Dumazet
2010-06-14 0:14 ` David Miller
2010-06-13 20:59 ` markus
2010-06-14 0:14 ` David Miller
2010-06-16 10:01 ` Christian Kujau
2010-06-17 15:05 ` Christoph Fritz
2010-06-14 0:13 ` David Miller
2010-06-14 14:13 ` Michael S. Tsirkin [this message]
2010-06-17 5:16 ` Shi, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614141313.GB25547@redhat.com \
--to=mst@redhat.com \
--cc=alex.shi@intel.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=netdev@vger.kernel.org \
--cc=tim.c.chen@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.