From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642 Date: Mon, 14 Jun 2010 17:10:34 +0100 Message-ID: <20100614161034.GF14604@rakim.wolfsonmicro.main> References: <201006141739.42346.PeterHuewe@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 95C63246E6 for ; Mon, 14 Jun 2010 18:10:36 +0200 (CEST) Content-Disposition: inline In-Reply-To: <201006141739.42346.PeterHuewe@gmx.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Huewe Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Kuninori Morimoto , Guennadi Liakhovetski , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > bool "FSI-AK4642 sound support" > depends on SND_SOC_SH4_FSI > select SND_SOC_AK4642 > + select I2C I'd have thought a depends was more appropriate. Arguably you want to depend on the SH I2C driver since the driver is useless without the relevant I2C controller. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 14 Jun 2010 16:10:34 +0000 Subject: Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642 Message-Id: <20100614161034.GF14604@rakim.wolfsonmicro.main> List-Id: References: <201006141739.42346.PeterHuewe@gmx.de> In-Reply-To: <201006141739.42346.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Huewe Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Kuninori Morimoto , Guennadi Liakhovetski , Liam Girdwood On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > bool "FSI-AK4642 sound support" > depends on SND_SOC_SH4_FSI > select SND_SOC_AK4642 > + select I2C I'd have thought a depends was more appropriate. Arguably you want to depend on the SH I2C driver since the driver is useless without the relevant I2C controller. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755746Ab0FNQKk (ORCPT ); Mon, 14 Jun 2010 12:10:40 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:40841 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753790Ab0FNQKh (ORCPT ); Mon, 14 Jun 2010 12:10:37 -0400 Date: Mon, 14 Jun 2010 17:10:34 +0100 From: Mark Brown To: Peter Huewe Cc: Liam Girdwood , linux-sh@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Guennadi Liakhovetski , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642 Message-ID: <20100614161034.GF14604@rakim.wolfsonmicro.main> References: <201006141739.42346.PeterHuewe@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006141739.42346.PeterHuewe@gmx.de> X-Cookie: I brake for chezlogs! User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > bool "FSI-AK4642 sound support" > depends on SND_SOC_SH4_FSI > select SND_SOC_AK4642 > + select I2C I'd have thought a depends was more appropriate. Arguably you want to depend on the SH I2C driver since the driver is useless without the relevant I2C controller.