From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Which partitioning schemes should be supported by GRUB?
Date: Mon, 14 Jun 2010 18:33:02 +0100 [thread overview]
Message-ID: <20100614173301.GR21862@riva.ucam.org> (raw)
In-Reply-To: <alpine.GSO.2.00.1006140954100.101795@oretfbsg.ybpny>
On Mon, Jun 14, 2010 at 09:55:09AM -0700, Seth Goldberg wrote:
>>>> === modified file 'kern/i386/pc/init.c'
>>>> --- kern/i386/pc/init.c 2010-05-21 18:08:48 +0000
>>>> +++ kern/i386/pc/init.c 2010-06-14 14:44:13 +0000
>>>> @@ -83,6 +83,14 @@ make_install_device (void)
>>>> grub_snprintf (ptr, sizeof (dev) - (ptr - dev), ")%s", grub_prefix);
>>>> grub_strcpy (grub_prefix, dev);
>>>> }
>>>> + else if (grub_prefix[1] == ',')
>>>> + {
>>>> + /* We have a prefix, but still need to fill in the boot drive. */
>>>> + grub_snprintf (dev, sizeof (dev),
>>>> + "(%cd%u%s", (grub_boot_drive & 0x80) ? 'h' : 'f',
>>>> + grub_boot_drive & 0x7f, grub_prefix + 1);
>>>> + grub_strcpy (grub_prefix, dev);
>>>> + }
>
> What about CD devices? Seems like you're limiting to hd and fd here
> (though CD may just be an alias for hd198 or something like that). Just
> checking :).
That part of my patch was just copied from immediately above, so doesn't
really change the current state.
grub-mkrescue has special code for dealing with CDs and setting an
appropriate prefix at run-time from the output of a 'search' command.
--
Colin Watson [cjwatson@ubuntu.com]
next prev parent reply other threads:[~2010-06-14 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 18:02 Which partitioning schemes should be supported by GRUB? Grégoire Sutre
2010-06-07 20:46 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-06-09 22:45 ` Grégoire Sutre
2010-06-09 23:03 ` C. P. Ghost
2010-06-12 16:32 ` Grégoire Sutre
2010-06-12 17:26 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-06-13 16:16 ` Grégoire Sutre
2010-06-14 11:37 ` Colin Watson
2010-06-14 13:07 ` richardvoigt
2010-06-14 13:25 ` Colin Watson
2010-06-14 15:02 ` Colin Watson
2010-06-14 15:58 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-06-14 16:43 ` Colin Watson
2010-06-14 16:55 ` Seth Goldberg
2010-06-14 17:33 ` Colin Watson [this message]
2010-06-14 17:12 ` Grégoire Sutre
2010-06-15 11:21 ` Colin Watson
2010-06-15 21:07 ` Grégoire Sutre
2010-06-16 13:01 ` Colin Watson
2010-06-16 23:31 ` Grégoire Sutre
2010-06-17 0:47 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-06-17 11:29 ` Colin Watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614173301.GR21862@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.