From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + fix-vc-vc_origin-on-take_over_console-checkpatch-fixes.patch added to -mm tree Date: Mon, 14 Jun 2010 14:31:03 -0700 Message-ID: <201006142131.o5ELV3BP032207@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:46443 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755907Ab0FNVbQ (ORCPT ); Mon, 14 Jun 2010 17:31:16 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, greg@kroah.com, qiaochong@loongson.cn The patch titled fix-vc-vc_origin-on-take_over_console-checkpatch-fixes has been added to the -mm tree. Its filename is fix-vc-vc_origin-on-take_over_console-checkpatch-fixes.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: fix-vc-vc_origin-on-take_over_console-checkpatch-fixes From: Andrew Morton WARNING: suspect code indent for conditional statements (16, 16) #60: FILE: drivers/char/vt.c:3062: + if(!vc->vc_origin) vc->vc_origin = (unsigned long)vc->vc_screenbuf; ERROR: space required before the open parenthesis '(' #60: FILE: drivers/char/vt.c:3062: + if(!vc->vc_origin) total: 1 errors, 1 warnings, 7 lines checked ./patches/fix-vc-vc_origin-on-take_over_console.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alan Cox Cc: Greg KH Cc: qiaochong Signed-off-by: Andrew Morton --- drivers/char/vt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/char/vt.c~fix-vc-vc_origin-on-take_over_console-checkpatch-fixes drivers/char/vt.c --- a/drivers/char/vt.c~fix-vc-vc_origin-on-take_over_console-checkpatch-fixes +++ a/drivers/char/vt.c @@ -3059,8 +3059,8 @@ static int bind_con_driver(const struct old_was_color = vc->vc_can_do_color; vc->vc_sw->con_deinit(vc); - if(!vc->vc_origin) - vc->vc_origin = (unsigned long)vc->vc_screenbuf; + if (!vc->vc_origin) + vc->vc_origin = (unsigned long)vc->vc_screenbuf; visual_init(vc, i, 0); set_origin(vc); update_attr(vc); _ Patches currently in -mm which might be from akpm@linux-foundation.org are linux-next.patch next-remove-localversion.patch i-need-old-gcc.patch include-linux-fsh-complete-hexification-of-fmode_-constants.patch intel_menlow-fix-memory-leaks-in-error-path-fix.patch x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent-fix.patch x86-olpc-add-support-for-calling-into-openfirmware-fix-fix.patch compal-laptop-added-jhl90-battery-hwmon-interface.patch dib3000mc-reduce-large-stack-usage-fix.patch hpet-factor-timer-allocate-from-open.patch leds-route-kbd-leds-through-the-generic-leds-layer.patch 3x59x-fix-pci-resource-management.patch altera_uart-simplify-altera_uart_console_putc-checkpatch-fixes.patch serial-mcf-dont-take-spinlocks-in-already-protected-functions-fix.patch scsi-remove-private-bit-macros.patch vfs-use-kmalloc-to-allocate-fdmem-if-possible.patch mm.patch tmpfs-quick-token-library-to-allow-scalable-retrieval-of-tokens-from-token-jar.patch mm-vmap-area-cache-fix.patch mm-track-the-root-oldest-anon_vma-fix.patch oom-improve-commentary-in-dump_tasks.patch oom-sacrifice-child-with-highest-badness-score-for-parent-protect-dereferencing-of-tasks-comm.patch oom-select-task-from-tasklist-for-mempolicy-ooms-add-has_intersects_mems_allowed-uma-variant.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch include-linux-compiler-gcch-use-__same_type-in-__must_be_array.patch mmc-recognize-csd-structure-fix.patch fix-vc-vc_origin-on-take_over_console-checkpatch-fixes.patch rtc-fixes-and-new-functionality-for-fm3130-fix.patch delay-accounting-re-implement-c-for-getdelaysc-to-report-information-on-a-target-command-checkpatch-fixes.patch kfifo-add-example-files-to-the-kernel-sample-directory-checkpatch-fixes.patch reiser4-export-remove_from_page_cache-fix.patch reiser4-export-find_get_pages.patch reiser4.patch reiser4-writeback_inodes-implementation-fix.patch reiser4-fixups.patch reiser4-broke.patch journal_add_journal_head-debug.patch slab-leaks3-default-y.patch put_bh-debug.patch getblk-handle-2tb-devices.patch