From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48958 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOIeR-00011z-W7 for qemu-devel@nongnu.org; Mon, 14 Jun 2010 19:01:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOIWc-0000WT-QG for qemu-devel@nongnu.org; Mon, 14 Jun 2010 18:53:03 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:48844) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOIWc-0000WE-CY for qemu-devel@nongnu.org; Mon, 14 Jun 2010 18:53:02 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic. Date: Mon, 14 Jun 2010 23:52:58 +0100 References: <1275659074-4516-1-git-send-email-kraxel@redhat.com> <4C0E4323.90808@redhat.com> <4C166187.2080805@codemonkey.ws> In-Reply-To: <4C166187.2080805@codemonkey.ws> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201006142352.59262.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann > >> This suggests we are incorrectly coalescing writes, and we should > >> actually be > >> notifying qemu when (at least) he first write occurs. If we aren't > >> outputting > >> anything we don't want to be waking up periodically just to flush an > >> empty > >> MMIO buffer. > > > > That is completely unrelated to this patch though. The patch doesn't > > change mmio flush behaviour at all. And the periodic wakeup was there > > even before the mmio flush patch was added. Even without gui, > > although I can't see a obvious reason for it ... > > Agreed. Regardless of the periodic mmio flush, having a separate > nographic timer isn't terribly helpful IMHO. I guess what I was objecting to is formalising this a "gui_timer" rather than "arbitrary_polling_hack_timer". Paul