From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: simplify xfs_vm_writepage
Date: Tue, 15 Jun 2010 11:50:47 +1000 [thread overview]
Message-ID: <20100615015047.GO6590@dastard> (raw)
In-Reply-To: <20100611161512.404472115@bombadil.infradead.org>
On Fri, Jun 11, 2010 at 12:13:15PM -0400, Christoph Hellwig wrote:
> The writepage implementation in XFS still tries to deal with dirty but
> unmapped buffers which used to caused by writes through shared mmaps. Since
> the introduction of ->page_mkwrite these can't happen anymore, so remove the
> code dealing with them.
>
> Note that the all_bh variable which causes us to start I/O on all buffers on
> the pages was controlled by the count of unmapped buffers, which also
> included those not actually dirty. It's now unconditionally initialized to
> 0 but set to 1 for the case of small file size extensions. It probably can
> be removed entirely, but that's left for another patch.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-15 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 16:13 [PATCH 0/3] simplify the writeback code Christoph Hellwig
2010-06-11 16:13 ` [PATCH 1/3] xfs: fix corruption case for block size < page size Christoph Hellwig
2010-06-15 1:21 ` Dave Chinner
2010-06-11 16:13 ` [PATCH 2/3] xfs: simplify xfs_vm_releasepage Christoph Hellwig
2010-06-15 1:37 ` Dave Chinner
2010-06-15 6:22 ` Christoph Hellwig
2010-06-11 16:13 ` [PATCH 3/3] xfs: simplify xfs_vm_writepage Christoph Hellwig
2010-06-15 1:50 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615015047.GO6590@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.