From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: npiggin@suse.de, viro@zeniv.linux.org.uk, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: new truncate sequence
Date: Tue, 15 Jun 2010 12:19:44 +1000 [thread overview]
Message-ID: <20100615021944.GQ6590@dastard> (raw)
In-Reply-To: <20100614091731.GA22088@infradead.org>
On Mon, Jun 14, 2010 at 05:17:31AM -0400, Christoph Hellwig wrote:
> Convert XFS to the new truncate sequence. We still can have errors after
> updating the file size in xfs_setattr, but these are real I/O errors and lead
> to a transaction abort and filesystem shutdown, so they are not an issue.
>
> Errors from ->write_begin and write_end can now be handled correctly because
> we can actually get rid of the delalloc extents while previous the buffer
> state was stipped in block_invalidatepage.
>
> There is still no error handling for ->direct_IO, because doing so will need
> some major restructuring given that we only have the iolock shared and do not
> hold i_mutex at all. Fortunately leaving the normally allocated blocks behind
> there is not a major issue and this will get cleaned up by xfs_free_eofblock
> later.
>
> Note: the patch is against Al's vfs.git tree as that contains the nessecary
> preparations. I'd prefer to get it applied there so that we can get some
> testing in linux-next.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
It looks sane, but I haven't done any testing on it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-15 2:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 9:17 [PATCH] xfs: new truncate sequence Christoph Hellwig
2010-06-15 2:19 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615021944.GQ6590@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.