From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: alsa-devel@vger.kernel.org, linux-input@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH RFC 2/3] input: wm97xx: set GPIOs with AC97 GPIO busops if implemented
Date: Tue, 15 Jun 2010 17:27:55 +0100 [thread overview]
Message-ID: <20100615162755.GM14510@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <AANLkTil-WxjFdE5oGEJklu_cA2o-23TCLjqD8sz-iMLm@mail.gmail.com>
On Tue, Jun 15, 2010 at 06:17:18PM +0200, Manuel Lauss wrote:
> On Tue, Jun 15, 2010 at 6:08 PM, Mark Brown
> > It seems like it'd be easier to just do this as a generic AC'97 thing
> > rather than adding it to the WM97xx driver - that way any CODEC that has
> > GPIO support can use it, we don't have to add custom per-CODEC GPIO APIs.
> > If you're using the WM97xx-specific code you're already doing something
> > custom so it's not much loss to use a generic thing.
> Oh, now I get it. Hmm, what about setting pin direction? That
> certainly is per-codec, no?
IIRC, yes - I'd need to check. I'd guess a lot of devices will be fixed
function and only support one direction.
next prev parent reply other threads:[~2010-06-15 16:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 15:55 [PATCH RFC 0/3] WM97xx AC97 GPIO support Manuel Lauss
2010-06-15 15:55 ` [PATCH RFC 1/3] sound: ac97: Add GPIO manipulation hooks Manuel Lauss
2010-06-15 16:02 ` Mark Brown
2010-06-15 16:13 ` Manuel Lauss
2010-06-15 16:13 ` Manuel Lauss
2010-06-16 7:55 ` Takashi Iwai
2010-06-16 7:55 ` Takashi Iwai
2010-06-16 8:00 ` Manuel Lauss
2010-06-16 8:00 ` Manuel Lauss
2010-06-16 12:52 ` Mark Brown
2010-06-16 12:52 ` Mark Brown
2010-06-15 16:02 ` Mark Brown
2010-06-15 15:55 ` Manuel Lauss
2010-06-15 15:55 ` [PATCH RFC 2/3] input: wm97xx: set GPIOs with AC97 GPIO busops if implemented Manuel Lauss
2010-06-15 16:08 ` Mark Brown
2010-06-15 16:08 ` Mark Brown
2010-06-15 16:17 ` Manuel Lauss
2010-06-15 16:17 ` Manuel Lauss
2010-06-15 16:27 ` Mark Brown [this message]
2010-06-15 16:27 ` Mark Brown
2010-06-15 15:55 ` Manuel Lauss
2010-06-15 15:55 ` [PATCH RFC 3/3] sound: asoc: au1x: implement AC97 GPIO access Manuel Lauss
2010-06-15 15:55 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615162755.GM14510@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=manuel.lauss@googlemail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.