From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/6] writeback: fix writeback completion notifications
Date: Tue, 15 Jun 2010 19:30:23 +0200 [thread overview]
Message-ID: <20100615173023.GA6893@lst.de> (raw)
In-Reply-To: <20100615172515.GF3347@quack.suse.cz>
On Tue, Jun 15, 2010 at 07:25:15PM +0200, Jan Kara wrote:
> > Also rename bdi_wait_on_work_clear to bdi_wait_on_work_done and inline
> What I find slightly misleading on bdi_wait_on_work_done is that work
> isn't always "done" when this returns. For WB_SYNC_NONE writeback this
> function returns as soon as writeback thread starts the work... But I don't
> have a better name.
Well, the "work" actually is done. For WB_SYNC_NONE that is just
kicking off the writeback, not waiting for it.
next prev parent reply other threads:[~2010-06-15 17:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 16:14 [PATCH 0/6] writeback fixes - slow unmount and others Christoph Hellwig
2010-06-08 16:14 ` [PATCH 1/6] writeback: fix writeback completion notifications Christoph Hellwig
2010-06-08 19:50 ` Jens Axboe
2010-06-15 17:25 ` Jan Kara
2010-06-15 17:30 ` Christoph Hellwig [this message]
2010-06-08 16:14 ` [PATCH 2/6] writeback: queue work on stack in writeback_inodes_sb Christoph Hellwig
2010-06-08 19:51 ` Jens Axboe
2010-06-08 16:14 ` [PATCH 3/6] writeback: enforce s_umount locking " Christoph Hellwig
2010-06-15 17:54 ` Jan Kara
2010-06-15 17:59 ` Christoph Hellwig
2010-06-15 18:04 ` Jan Kara
2010-06-08 16:14 ` [PATCH 4/6] writeback: fix writeback_inodes_wb from writeback_inodes_sb Christoph Hellwig
2010-06-08 19:51 ` Jens Axboe
2010-06-09 12:25 ` Christoph Hellwig
2010-06-09 12:29 ` Jens Axboe
2010-06-08 16:15 ` [PATCH 5/6] writeback: simplify wakeup_flusher_threads Christoph Hellwig
2010-06-08 19:51 ` Jens Axboe
2010-06-08 16:15 ` [PATCH 6/6] writeback: simplify and split bdi_start_writeback Christoph Hellwig
2010-06-08 19:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615173023.GA6893@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.