From: Dan Carpenter <error27@gmail.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] mempolicy: fix dangling reference to tmpfs superblock mpol
Date: Tue, 15 Jun 2010 21:11:43 +0200 [thread overview]
Message-ID: <20100615191143.GE5483@bicker> (raw)
In-Reply-To: <1276624037.5044.47.camel@useless.americas.hpqcorp.net>
On Tue, Jun 15, 2010 at 01:47:17PM -0400, Lee Schermerhorn wrote:
> Against 2.6.35-rc1+
>
> My patch to "Factor out duplicate put/frees in mpol_shared_policy_init()
> to a common return path"; and Dan Carpenter's fix thereto both left a
> dangling reference to the incoming tmpfs superblock mempolicy structure.
> A similar leak was introduced earlier when the nodemask was moved offstack
> to the scratch area despite the note in the comment block regarding the
> incoming ref.
>
Yup. You're right.
Acked-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
prev parent reply other threads:[~2010-06-15 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 17:47 [PATCH] mempolicy: fix dangling reference to tmpfs superblock mpol Lee Schermerhorn
2010-06-15 19:11 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615191143.GE5483@bicker \
--to=error27@gmail.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.