From: Arjan van de Ven <arjan@infradead.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Jiri Slaby <jslaby@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait_cpu)
Date: Tue, 15 Jun 2010 23:05:41 -0700 [thread overview]
Message-ID: <20100615230541.5db5078e@infradead.org> (raw)
In-Reply-To: <20100615161303.GA4102@swordfish.minsk.epam.com>
On Tue, 15 Jun 2010 19:13:03 +0300
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
>
> I've changed struct tick_sched to match passed *ts and cpu. Also
> changed "&per_cpu(tick_cpu_sched, cpu)" call to "struct tick_sched
> *tick_get_tick_sched(int cpu)" which we already have.
>
> But I don't really like this part:
> struct tick_sched *tick_get_tick_sched(int cpu)
> {
> struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
> ts->cpu = cpu;
> ^^^^^^^^^^^^^
> return ts;
> }
>
> Please kindly review.
can we do this bit once, when the ts structure gets initialized?
it's not like the cpu value will ever change...
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2010-06-16 6:03 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 20:33 BUG: using smp_processor_id() in preemptible code: s2disk Sergey Senozhatsky
2010-06-13 20:33 ` Maxim Levitsky
2010-06-13 23:36 ` Rafael J. Wysocki
2010-06-14 14:09 ` Sergey Senozhatsky
2010-06-14 14:09 ` Sergey Senozhatsky
2010-06-14 14:23 ` Rafael J. Wysocki
2010-06-14 14:23 ` Rafael J. Wysocki
2010-06-14 14:38 ` Arjan van de Ven
2010-06-14 14:38 ` Arjan van de Ven
2010-06-14 14:54 ` Sergey Senozhatsky
2010-06-14 14:54 ` Sergey Senozhatsky
2010-06-14 15:01 ` Arjan van de Ven
2010-06-14 15:17 ` Sergey Senozhatsky
2010-06-15 3:40 ` Arjan van de Ven
2010-06-15 6:19 ` [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait_cpu) Sergey Senozhatsky
2010-06-15 14:24 ` Arjan van de Ven
2010-06-15 14:50 ` Sergey Senozhatsky
2010-06-15 15:08 ` Arjan van de Ven
2010-06-15 15:08 ` Arjan van de Ven
2010-06-15 15:23 ` Sergey Senozhatsky
2010-06-15 15:31 ` Sergey Senozhatsky
2010-06-15 15:31 ` Sergey Senozhatsky
2010-06-15 15:23 ` Sergey Senozhatsky
2010-06-15 16:13 ` Sergey Senozhatsky
2010-06-16 6:05 ` Arjan van de Ven
2010-06-16 6:05 ` Arjan van de Ven [this message]
2010-06-16 9:34 ` Sergey Senozhatsky
2010-06-16 9:34 ` Sergey Senozhatsky
2010-06-15 16:13 ` Sergey Senozhatsky
2010-06-17 6:29 ` [PATCH] cpuidle: avoid using smp_processor_id() in preemptible code (nr_iowait_cpu) v4 Sergey Senozhatsky
2010-06-17 6:29 ` Sergey Senozhatsky
2010-06-17 6:43 ` Arjan van de Ven
2010-06-17 6:43 ` Arjan van de Ven
2010-06-17 6:59 ` Andrew Morton
2010-06-17 7:04 ` Andrew Morton
2010-06-17 7:04 ` Andrew Morton
2010-06-17 7:34 ` Sergey Senozhatsky
2010-06-17 7:34 ` Sergey Senozhatsky
2010-06-17 6:59 ` Andrew Morton
2010-06-25 14:39 ` Peter Zijlstra
2010-06-25 14:39 ` Peter Zijlstra
2010-06-30 19:58 ` Andrew Morton
2010-06-30 19:58 ` Andrew Morton
2010-07-01 6:17 ` Sergey Senozhatsky
2010-07-01 6:17 ` Sergey Senozhatsky
2010-07-01 7:07 ` [PATCH] sched: Cure nr_iowait_cpu() users Peter Zijlstra
2010-07-01 7:07 ` Peter Zijlstra
2010-07-01 8:18 ` Sergey Senozhatsky
2010-07-01 8:18 ` Sergey Senozhatsky
2010-07-01 8:45 ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
2010-06-15 14:50 ` [PATCH] avoid using smp_processor_id() in preemptible code (nr_iowait_cpu) Sergey Senozhatsky
2010-06-15 14:24 ` Arjan van de Ven
2010-06-15 6:19 ` Sergey Senozhatsky
2010-06-15 3:40 ` BUG: using smp_processor_id() in preemptible code: s2disk Arjan van de Ven
2010-06-14 15:17 ` Sergey Senozhatsky
2010-06-14 15:01 ` Arjan van de Ven
2010-06-13 23:36 ` Rafael J. Wysocki
2010-06-13 20:33 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615230541.5db5078e@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=maximlevitsky@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.