All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: support barriers without FLUSH feature
Date: Wed, 16 Jun 2010 11:26:32 +0930	[thread overview]
Message-ID: <201006161126.32894.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100615124348.GA25804@lst.de>

On Tue, 15 Jun 2010 10:13:48 pm Christoph Hellwig wrote:
> If we want to support barriers with the cache=writethrough mode in qemu
> we need to tell the block layer that we only need queue drains to
> implement a barrier.  Follow the model set by SCSI and IDE and assume
> that there is no volatile write cache if the host doesn't advertize it.
> While this might imply working barriers on old qemu versions or other
> hypervisors that actually have a volatile write cache this is only a
> cosmetic issue - these hypervisors don't guarantee any data integrity
> with or without this patch, but with the patch we at least provide
> data ordering.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, applied.

Cheers,
Rusty.

      reply	other threads:[~2010-06-16  1:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 12:43 [PATCH] virtio_blk: support barriers without FLUSH feature Christoph Hellwig
2010-06-16  1:56 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006161126.32894.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=hch@lst.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.