From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 05/12] Modify ussd parser
Date: Thu, 17 Jun 2010 04:35:38 -0500 [thread overview]
Message-ID: <201006170435.39056.denkenz@gmail.com> (raw)
In-Reply-To: <CE761E84DADF2947A4AF22FB8D97A4731ED17F93@shsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
Hi Yang,
> >Please drop this patch for now, the problem is that all AT modems do not
> >actually report USSD data as a PDU, instead they actually decode this into
> > the current character set of the modem (as set by +CSCS.) The spec
> > really screwed up on this one.
> >
> >This is one of the weirder parts of the spec, I don't think USSDs that are
> > not GSM 7 bit are even possible. At least not on the AT modems I've
> > encountered.
>
> When it's GSM 7-bit, is it needed to call unpack_7bit() before calling
> convert_gsm_to_utf8()? The isimodem does so. Also the status doesn't have
Again, the AT modems do not pass in a raw PDU here unlike isi modems. They
just give you the string in whatever the character set is set with +CSCS. If
it happens to be UTF8, it will be UTF8. If it happens to be GSM, it'll be
GSM. The current driver just assumes GSM, however we really need to know the
character set. Generally this works out because the characters are ASCII, but
the current driver does not work in all situations.
> an initial value, so in some path of code status would have an uncertain
> value, which may cause problem when calling ofono_ussd_notify(). Maybe the
I don't see any issue, from what I can tell status is always set appropriately
before calling ussd_notify. Can you be more specific about your concern here?
Regards,
-Denis
next prev parent reply other threads:[~2010-06-17 9:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 9:43 [PATCH 01/12] stk: Add parser for send ss commands Yang Gu
2010-06-13 9:43 ` [PATCH 02/12] teststk: Add test for send ss parser Yang Gu
2010-06-13 9:43 ` [PATCH 03/12] stk: Add parser for send ussd commands Yang Gu
2010-06-16 22:44 ` Denis Kenzior
2010-06-13 9:43 ` [PATCH 04/12] teststk: Add test for send ussd parser Yang Gu
2010-06-13 9:43 ` [PATCH 05/12] Modify " Yang Gu
2010-06-16 22:48 ` Denis Kenzior
2010-06-17 10:33 ` Gu, Yang
2010-06-17 9:35 ` Denis Kenzior [this message]
2010-06-13 9:43 ` [PATCH 06/12] Refactor " Yang Gu
2010-06-16 22:49 ` Denis Kenzior
2010-06-21 14:09 ` Aki Niemi
2010-06-21 14:08 ` Aki Niemi
2010-06-13 9:43 ` [PATCH 07/12] Add several proactive command parsers Yang Gu
2010-06-13 9:43 ` [PATCH 08/12] stk: Add parser for cell broadcast page objects Yang Gu
2010-06-13 9:43 ` [PATCH 09/12] stk: Add parser for bcch channel list objects Yang Gu
2010-06-13 9:43 ` [PATCH 10/12] stk: Add parser for timing advance objects Yang Gu
2010-06-16 22:50 ` Denis Kenzior
2010-06-16 23:19 ` andrzej zaborowski
2010-06-17 1:44 ` Gu, Yang
2010-06-13 9:43 ` [PATCH 11/12] stk: Add parser for PDP activation param objects Yang Gu
2010-06-13 9:43 ` [PATCH 12/12] stk: Add parser for UTRAN meas qualifier objects Yang Gu
2010-06-16 22:42 ` [PATCH 01/12] stk: Add parser for send ss commands Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006170435.39056.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.