From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 0/2 v4] Writeback livelock avoidance for data integrity writes Date: Thu, 17 Jun 2010 09:43:50 +0200 Message-ID: <20100617074350.GA3453@quack.suse.cz> References: <1276706031-29421-1-git-send-email-jack@suse.cz> <20100616221541.GV6590@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , npiggin@suse.de To: Dave Chinner Return-path: Received: from cantor2.suse.de ([195.135.220.15]:45794 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756700Ab0FQHoR (ORCPT ); Thu, 17 Jun 2010 03:44:17 -0400 Content-Disposition: inline In-Reply-To: <20100616221541.GV6590@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 17-06-10 08:15:41, Dave Chinner wrote: > On Wed, Jun 16, 2010 at 06:33:49PM +0200, Jan Kara wrote: > > Hello, > > > > here is the fourth version of the writeback livelock avoidance patches > > for data integrity writes. To quickly summarize the idea: we tag dirty > > pages at the beginning of write_cache_pages with a new TOWRITE tag and > > then write only tagged pages to avoid parallel writers to livelock us. > > See changelogs of the patches for more details. > > I have tested the patches with fsx and a test program I wrote which > > checks that if we crash after fsync, the data is indeed on disk. > > If there are no more concerns, can these patches get merged? > > Has it been run through xfstests? I'd suggest doing that at least > with XFS as there are several significant sync sanity tests for XFS > in the suite... I've run it through XFSQA with ext3 & ext4 before submitting. I'm running a test with xfs now. Honza -- Jan Kara SUSE Labs, CR