All of lore.kernel.org
 help / color / mirror / Atom feed
From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/reporter.c
Date: 17 Jun 2010 13:15:53 -0000	[thread overview]
Message-ID: <20100617131553.18299.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mbroz at sourceware.org	2010-06-17 13:15:52

Modified files:
	.              : WHATS_NEW 
	tools          : reporter.c 

Log message:
	Fix exit code when requesting help using documented -o help option.
	
	IOW fix lvs -o help
	...
	Command failed with status code 5.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1616&r2=1.1617
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/reporter.c.diff?cvsroot=lvm2&r1=1.60&r2=1.61

--- LVM2/WHATS_NEW	2010/06/17 12:48:54	1.1616
+++ LVM2/WHATS_NEW	2010/06/17 13:15:51	1.1617
@@ -1,5 +1,6 @@
 Version 2.02.68 -
 ===============================
+  Fix exit code when requesting help using documented -o help option.
   Do not use internal DLM lock definitions in generic LVM2 clvmd code.
   Add dmeventd man page.
   Update lvresize/extend/reduce manpages with --nofsck, --resizefs options.
--- LVM2/tools/reporter.c	2010/04/23 19:10:20	1.60
+++ LVM2/tools/reporter.c	2010/06/17 13:15:52	1.61
@@ -362,6 +362,8 @@
 					  separator, aligned, buffered,
 					  headings, field_prefixes, quoted,
 					  columns_as_rows))) {
+		if (!strcasecmp(options, "help") || !strcmp(options, "?"))
+			return r;
 		stack;
 		return ECMD_FAILED;
 	}



             reply	other threads:[~2010-06-17 13:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 13:15 mbroz [this message]
2010-06-21 15:13 ` LVM2 ./WHATS_NEW tools/reporter.c Alasdair G Kergon
2010-06-21 15:15 ` Alasdair G Kergon
2010-06-21 15:21   ` Milan Broz
  -- strict thread matches above, loose matches on Subject: below --
2008-01-20  1:23 agk
2007-02-14 15:18 agk
2007-01-27  2:09 agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100617131553.18299.qmail@sourceware.org \
    --to=mbroz@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.