All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: Alex Lee <alexlee188@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"clemens@ladisch.de" <clemens@ladisch.de>
Subject: Re: [PATCH 2/5] ALSA: usb-audio: unify UAC macros and struct names
Date: Thu, 17 Jun 2010 17:26:26 +0200	[thread overview]
Message-ID: <20100617152626.GL17833@buzzloop.caiaq.de> (raw)
In-Reply-To: <AANLkTimtpdMFSDTEiDNLI0HzMPdRwJmsvyG0AuWGKv1r@mail.gmail.com>

(hint, hint: don't top-post :))

On Thu, Jun 17, 2010 at 08:21:22AM -0700, Alex Lee wrote:
> It will not help existing codes, I agree.  But it may make writing new UAC2
> specific code easier?

Not as long as most of the code stays hybrid for both versions. If there
were versions of these enum values for both UAC1 and UAC2, you would
need to choose one of them in the parser codes. Which one you go for
doesn't actually make any difference as they're both the same, but the
code would read as if it was specific to any version.

I'd say this would add more to the confusion, and not ease any.


Daniel

  parent reply	other threads:[~2010-06-17 15:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16 15:57 usb-audio: some cleanup patches for 2.6.36 Daniel Mack
2010-06-16 15:57 ` [PATCH 1/5] ALSA: usb-audio: clean up includes in clock.c Daniel Mack
2010-06-16 15:57 ` [PATCH 2/5] ALSA: usb-audio: unify UAC macros and struct names Daniel Mack
2010-06-16 17:34   ` Takashi Iwai
2010-06-16 17:40     ` Daniel Mack
2010-06-16 20:21       ` Takashi Iwai
     [not found]         ` <6E4AF70D-1E90-48FF-9EBB-0882C6ABAF34@gmail.com>
2010-06-17 12:07           ` Daniel Mack
     [not found]             ` <AANLkTimtpdMFSDTEiDNLI0HzMPdRwJmsvyG0AuWGKv1r@mail.gmail.com>
2010-06-17 15:26               ` Daniel Mack [this message]
2010-06-16 15:57 ` [PATCH 3/5] ALSA: usb-midi: whitespace fixes Daniel Mack
2010-06-16 15:57 ` [PATCH 4/5] ALSA: usb-audio: move and add some comments Daniel Mack
2010-06-16 15:57 ` [PATCH 5/5] ALSA: usb-audio: simplify control interface access Daniel Mack
2010-06-23 14:22 ` usb-audio: some cleanup patches for 2.6.36 Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100617152626.GL17833@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=alexlee188@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.