Re: [PATCH 1/4] hsu: driver for Medfield High Speed UART device

[Greg KH <greg@kroah.com>]

On Thu, Jun 17, 2010 at 11:01:47AM +0100, Alan Cox wrote:
> From: Feng Tang <feng.tang@intel.com>
> 
> This is a PCI & UART driver, which suppors both PIO and DMA mode
> UART operation. It has 3 identical UART ports and one internal
> DMA controller.
> 
> Current FW will export 4 pci devices for hsu: 3 uart ports and 1
> dma controller, each has one IRQ line. And we need to discuss the
> device model, one PCI device covering whole HSU should be a better
> model, but there is a problem of how to export the 4 IRQs info
> 
> Current driver set the highest baud rate to 2746800bps, which is
> easy to scale down to 115200/230400.... To suport higher baud rate,
> we need add special process, change DLAB/DLH/PS/DIV/MUL registers
> all together.
> 
> 921600 is the highest baud rate that has been tested with Bluetooth
> modem connected to HSU port 0. Will test more when there is right
> BT firmware.
> 
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/serial/Kconfig      |    9 
>  drivers/serial/Makefile     |    1 
>  drivers/serial/mfd.c        | 1488 +++++++++++++++++++++++++++++++++++++++++++

When building with this patch, I get the following build error:
  CC [M]  drivers/serial/mfd.o
  drivers/serial/mfd.c: In function ‘serial_hsu_probe’:
  drivers/serial/mfd.c:1338:22: error: ‘serial_hsu_console’ undeclared (first use in this function)

So I can't take this, or the second patch (which doesn't fix this
problem).

Care to redo them so that the build is not broken?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html