All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Greg KH <greg@kroah.com>
Cc: Jeff Dike <jdike@addtoit.com>, Alan Cox <alan@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove Hayes ESP ioctls
Date: Thu, 17 Jun 2010 22:41:05 +0200	[thread overview]
Message-ID: <201006172241.05878.arnd@arndb.de> (raw)
In-Reply-To: <20100617201417.GA2873@kroah.com>

On Thursday 17 June 2010 22:14:17 Greg KH wrote:
> --- a/include/asm-generic/ioctls.h
> +++ b/include/asm-generic/ioctls.h
> @@ -87,12 +87,10 @@
>  #define TIOCGICOUNT    0x545D  /* read serial port inline interrupt counts */
>  
>  /*
> - * some architectures define FIOQSIZE as 0x545E, which is used for
> - * TIOCGHAYESESP on others
> + * Some arches already define FIOQSIZE due to a historical
> + * conflict with a Hayes modem-specific ioctl value.
>   */
>  #ifndef FIOQSIZE
> -# define TIOCGHAYESESP 0x545E  /* Get Hayes ESP configuration */
> -# define TIOCSHAYESESP 0x545F  /* Set Hayes ESP configuration */
>  # define FIOQSIZE      0x5460
>  #endif

Yes, that looks right. I had introduced the #ifdef originally, but
did not look closely enough at the patch now.

	Arnd

  reply	other threads:[~2010-06-17 20:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 16:00 [PATCH] Remove Hayes ESP ioctls Jeff Dike
2010-06-17 17:28 ` Greg KH
2010-06-17 19:15   ` Jeff Dike
2010-06-17 19:44     ` Arnd Bergmann
2010-06-17 20:03       ` Greg KH
2010-06-17 20:09     ` Greg KH
2010-06-17 20:14       ` Greg KH
2010-06-17 20:41         ` Arnd Bergmann [this message]
2010-06-17 21:29           ` Jeff Dike
2010-06-17 22:03             ` Greg KH
2010-06-17 23:18               ` Jeff Dike
2010-06-17 20:18     ` patch tty-remove-hayes-esp-ioctls.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006172241.05878.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=alan@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.