From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] block: unify flags for struct bio and struct request Date: Fri, 18 Jun 2010 11:14:43 +0200 Message-ID: <20100618091443.GA17410@lst.de> References: <20100618074704.GB13358@lst.de> <20100618090753.GF6138@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , axboe@kernel.dk, linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from verein.lst.de ([213.95.11.210]:36429 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758129Ab0FRJOp (ORCPT ); Fri, 18 Jun 2010 05:14:45 -0400 Content-Disposition: inline In-Reply-To: <20100618090753.GF6138@laptop> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jun 18, 2010 at 07:07:53PM +1000, Nick Piggin wrote: > Any reason not to make REQ_RAHEAD include REQ_FAILFAST_MASK? Yeah, could do that. Initially I planned to just remove REQ_RAHEAD, but the MD code will cancel read-ahead requests even without a real error.