All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Mike Heinz <michael.heinz-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
	"ewg-G2znmakfqn7U1rindQTSdQ@public.gmane.org"
	<ewg-G2znmakfqn7U1rindQTSdQ@public.gmane.org>
Subject: Re: [PATCH] pkey fix for ipoib - resubmission
Date: Fri, 18 Jun 2010 11:22:16 -0600	[thread overview]
Message-ID: <20100618172216.GK4630@obsidianresearch.com> (raw)
In-Reply-To: <4C2744E8AD2982428C5BFE523DF8CDCB49D09E7C6D-amwN6d8PyQWXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>

On Fri, Jun 18, 2010 at 12:09:25PM -0500, Mike Heinz wrote:

> 1. Suppress activation of interface and join multicast group queries
> (it will fail anyway) until hca port is initialized. When port
> becomes active - update pkey value and move on.

> 2. Update broadcast mgid based on actual pkey, then issue join
> broadcast group request.

What happens if the SM reprograms the pkey table later?

I'm not sure this is the right approach.. See the recent dicussion
about using pkey indexes at all.

Each ipoib interface is assigned a pkey, by number, not index. If the
SM has not supplied that pkey to the port then the ipoib should not
come up. If the SM adds it later then it should come up, if it the SM
removes it later then it should go down.

The default ipoib interface uses the default pkey. If your network
need ipoib to use a different pkey then you have to change the pkey
number assignment when the ipoib interface is created, not magically
attempt to autoconfigure.

I believe you cannot safely change the broadcast GID once the ipoib
interface has started.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-06-18 17:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16 13:59 [PATCH] pkey fix for ipoib - resubmission Mike Heinz
     [not found] ` <4C2744E8AD2982428C5BFE523DF8CDCB49D09E7A43-amwN6d8PyQWXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-06-17 16:36   ` Eli Cohen
     [not found]     ` <AANLkTimLfiuWMpiUFGIvotG0aWiebXC5jv5kfgKUmG4a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-06-17 16:39       ` Mike Heinz
2010-06-18 17:09   ` Mike Heinz
     [not found]     ` <4C2744E8AD2982428C5BFE523DF8CDCB49D09E7C6D-amwN6d8PyQWXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-06-18 17:22       ` Jason Gunthorpe [this message]
     [not found]         ` <20100618172216.GK4630-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-06-18 17:32           ` [ewg] " Todd Rimmer
     [not found]             ` <5AEC2602AE03EB46BFC16C6B9B200DA816B75308EF-e4KNYiSEog6Xx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-06-18 17:46               ` Jason Gunthorpe
     [not found]                 ` <20100618174650.GL4630-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-06-18 17:56                   ` Todd Rimmer
     [not found]                     ` <5AEC2602AE03EB46BFC16C6B9B200DA816B75308F7-e4KNYiSEog6Xx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-06-18 18:19                       ` Jason Gunthorpe
     [not found]                         ` <20100618181921.GM4630-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-06-18 18:38                           ` Todd Rimmer
     [not found]                             ` <5AEC2602AE03EB46BFC16C6B9B200DA816B7530901-e4KNYiSEog6Xx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2010-06-18 21:46                               ` Jason Gunthorpe
2010-06-22  6:09                           ` Or Gerlitz
     [not found]                             ` <4C20537D.5080903-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-06-22 14:46                               ` Jason Gunthorpe
     [not found]                                 ` <20100622144607.GA7767-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-06-23  6:58                                   ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100618172216.GK4630@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=ewg-G2znmakfqn7U1rindQTSdQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michael.heinz-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.