From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW daemons/cmirrord/functions.c
Date: 18 Jun 2010 20:58:04 -0000 [thread overview]
Message-ID: <20100618205804.9372.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: jbrassow at sourceware.org 2010-06-18 20:58:04
Modified files:
. : WHATS_NEW
daemons/cmirrord: functions.c
Log message:
daemons/cmirrord/functions.c (part of cmirrord) was referencing
linux/kdev_t.h even though it wasn't needed. Strangely, it seems
to be causing problems on various architectures (i686) in the
function daemons/cmirrord/functions.c:disk_status_info()->sprintf.
I'm not sure why this is a problem since none of the macros in
kdev_t.h are used in that code, but it certainly doesn't hurt to
pull an unnecessary header and it seems to fix the problem.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1618&r2=1.1619
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/cmirrord/functions.c.diff?cvsroot=lvm2&r1=1.18&r2=1.19
--- LVM2/WHATS_NEW 2010/06/18 10:19:29 1.1618
+++ LVM2/WHATS_NEW 2010/06/18 20:58:04 1.1619
@@ -1,5 +1,6 @@
Version 2.02.68 -
===============================
+ Unneeded kdev_t.h reference causing harm for cmirrord on some archs.
Add man pages for lvmconf and unsupported lvmsadc and lvmsar tools.
Fix exit code when requesting help using documented -o help option.
Do not use internal DLM lock definitions in generic LVM2 clvmd code.
--- LVM2/daemons/cmirrord/functions.c 2010/01/22 00:43:28 1.18
+++ LVM2/daemons/cmirrord/functions.c 2010/06/18 20:58:04 1.19
@@ -15,7 +15,6 @@
#include <dirent.h>
#include <errno.h>
#include <fcntl.h>
-#include <linux/kdev_t.h>
#include <signal.h>
#include <sys/stat.h>
#include <time.h>
next reply other threads:[~2010-06-18 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 20:58 jbrassow [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-08 11:34 LVM2 ./WHATS_NEW daemons/cmirrord/functions.c zkabelac
2011-09-06 18:24 zkabelac
2010-12-20 13:57 zkabelac
2010-08-30 18:37 jbrassow
2010-08-17 23:56 jbrassow
2010-08-04 18:18 jbrassow
2010-01-15 18:48 jbrassow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618205804.9372.qmail@sourceware.org \
--to=jbrassow@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.